Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

PR26578, memory leak in parse_gnu_debugaltlink

Browse Source 
The associated check function doesn't do anything with its "data"
param, so nothing to adjust there.

	PR 26578
	* dwarf.c (parse_gnu_debugaltlink): Don't alloc build_id_data.
	(load_separate_debug_files): Use a stack var for build_id_data.
This commit is contained in:
Alan Modra
2020-09-09 16:38:36 +09:30
parent fb7331ae2b
commit dfbee68088
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
binutils/ChangeLog
View File

@@ -1,3 +1,9 @@
2020-09-09 Alan Modra <amodra@gmail.com>
PR 26578
* dwarf.c (parse_gnu_debugaltlink): Don't alloc build_id_data.
(load_separate_debug_files): Use a stack var for build_id_data.
2020-09-08 H.J. Lu <hongjiu.lu@intel.com>
PR ld/26587

9
binutils/dwarf.c
View File

@@ -10353,15 +10353,10 @@ parse_gnu_debugaltlink (struct dwarf_section * section, void * data)
if (id_len < 0x14)
return NULL;
build_id_data = calloc (1, sizeof * build_id_data);
if (build_id_data == NULL)
return NULL;
build_id_data = (Build_id_data *) data;
build_id_data->len = id_len;
build_id_data->data = section->start + namelen;
* (Build_id_data **) data = build_id_data;
return name;
}
@@ -10750,7 +10745,7 @@ load_separate_debug_files (void * file, const char * filename)
if (load_debug_section (gnu_debugaltlink, file))
{
Build_id_data * build_id_data;
Build_id_data build_id_data;
load_separate_debug_info (filename,
& debug_displays[gnu_debugaltlink].section,