Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

problem sourcing GDB script in interactive-mode on

Browse Source 
When interactive-mode is not auto, GDB always uses that setting to
determine whether to act as if the input stream is a terminal or not.
However, this setting should only be honored if the input stream is
the standard input stream.  Otherwise, we run into trouble while
source-ing a GDB script, as shown below (on x86_64-linux):

        % cat script
        print 1
        print 2
        % gdb  -q
        (gdb) set interactive-mode on
        (gdb) source script
        (gdb) print 3
        $1 = 3

The lack of output and the fact that the "print 3" command returned
a value saved in $1 (as opposed to $3) indicates that the script was
not even evaluated at all.

gdb/ChangeLog:

        * top.c (input_from_terminal_p): Restrict the use of interactive_mode
        to the case where instream is stdin.

gdb/testsuite/ChangeLog:

        * gdb.base/interact.exp: New testcase.
This commit is contained in:
Joel Brobecker
2011-01-13 23:01:10 +00:00
parent 7f71cd9831
commit de8fa76c44
4 changed files with 58 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/top.c
View File

@@ -1292,7 +1292,7 @@ show_interactive_mode (struct ui_file *file, int from_tty,
int
input_from_terminal_p (void)
{
if (interactive_mode != AUTO_BOOLEAN_AUTO)
if (interactive_mode != AUTO_BOOLEAN_AUTO && instream == stdin)
return interactive_mode == AUTO_BOOLEAN_TRUE;
if (batch_flag)