forked from Imagelibrary/binutils-gdb
Touches most files in bfd/, so likely will be blamed for everything..
o bfd_read and bfd_write lose an unnecessary param and become
bfd_bread and bfd_bwrite.
o bfd_*alloc now all take a bfd_size_type arg, and will error if
size_t is too small. eg. 32 bit host, 64 bit bfd, verrry big files
or bugs in linker scripts etc.
o file_ptr becomes a bfd_signed_vma. Besides matching sizes with
various other types involved in handling sections, this should make
it easier for bfd to support a 64 bit off_t on 32 bit hosts that
provide it.
o I've made the H_GET_* and H_PUT_* macros (which invoke bfd_h_{get,put}_*)
generally available. They now cast their args to bfd_vma and
bfd_byte * as appropriate, which removes a swag of casts from the
source.
o Bug fixes to bfd_get8, aix386_core_vec, elf32_h8_relax_section, and
aout-encap.c.
o Zillions of formatting and -Wconversion fixes.
This commit is contained in:
11
bfd/format.c
11
bfd/format.c
@@ -142,10 +142,11 @@ bfd_check_format_matches (abfd, format, matching)
|
||||
|
||||
if (matching)
|
||||
{
|
||||
bfd_size_type amt;
|
||||
|
||||
*matching = NULL;
|
||||
matching_vector =
|
||||
(char **) bfd_malloc (sizeof (char *)
|
||||
* 2 * _bfd_target_vector_entries);
|
||||
amt = sizeof (char *) * 2 * _bfd_target_vector_entries;
|
||||
matching_vector = (char **) bfd_malloc (amt);
|
||||
if (!matching_vector)
|
||||
return false;
|
||||
}
|
||||
@@ -159,7 +160,7 @@ bfd_check_format_matches (abfd, format, matching)
|
||||
/* If the target type was explicitly specified, just check that target. */
|
||||
if (!abfd->target_defaulted)
|
||||
{
|
||||
if (bfd_seek (abfd, (file_ptr)0, SEEK_SET) != 0) /* rewind! */
|
||||
if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0) /* rewind! */
|
||||
return false;
|
||||
|
||||
right_targ = BFD_SEND_FMT (abfd, _bfd_check_format, (abfd));
|
||||
@@ -210,7 +211,7 @@ bfd_check_format_matches (abfd, format, matching)
|
||||
|
||||
abfd->xvec = *target; /* Change BFD's target temporarily */
|
||||
|
||||
if (bfd_seek (abfd, (file_ptr)0, SEEK_SET) != 0)
|
||||
if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0)
|
||||
return false;
|
||||
|
||||
/* If _bfd_check_format neglects to set bfd_error, assume
|
||||
|
||||
Reference in New Issue
Block a user