Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Lint around file_ptr's (bfd's off_t's) and bfd_seek.

Browse Source 
* dbxread.c (read_dbx_symtab):  Use L_SET as bfd_seek arg.
(elfstab_build_psymtabs):  staboffset and stabstroffset args are
file_ptr's.
* dwarfread.c (struct dwfinfo):  Convert dbfoff, lnfoff to file_ptr.
(scan_compilation_units):  Punt unused filename arg.  dbfoff,
lnoffset, and curlnoffset are file_ptr's now.
(dwarf_build_psymtabs):  Drop desc and filename args; use
objfile.  dbfoff and lnoffset are file_ptr's now.
(read_ofile_symtab):  foffset is now file_ptr.  Use L_SET in bfd_seek.
* elfread.c (struct elfinfo):  dboffset and lnoffset are file_ptr's.
(elf_symfile_read):  Skip desc and filename args to
dwarf_build_psymtabs.  Pass file_ptr's to elfstab_build_psymtabs.
* gdb-stabs.h:  Use file_ptr rather than off_t.
* mipsread.c (fixup_symtab): f_ptr is a file_ptr.  Re-enable
compile-time debug check that someone turned off as "unused".
(read_the_mips_symtab):  st_filptr is a file_ptr.  Fix bfd_seek call.
* symfile.h:  Update dwarf_build_psymtabs and
elfstab_build_psymtabs prototypes.
* xcoffread.c (init_stringtab, init_lineno, xcoff_symfile_read):
Use file_ptr offsets.  bfd_seeks use L_SET.
This commit is contained in:
John Gilmore
1992-10-15 13:40:40 +00:00
parent 6803d8186f
commit d5931d797d
6 changed files with 106 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
gdb/xcoffread.c
View File

@@ -174,7 +174,7 @@ static int
init_debugsection PARAMS ((bfd *));
static int
init_stringtab PARAMS ((bfd *, long, struct objfile *));
init_stringtab PARAMS ((bfd *, file_ptr, struct objfile *));
static void
xcoff_symfile_init PARAMS ((struct objfile *));
@@ -196,7 +196,7 @@ static struct section_offsets *
xcoff_symfile_offsets PARAMS ((struct objfile *, CORE_ADDR));
static int
init_lineno PARAMS ((bfd *, long, int));
init_lineno PARAMS ((bfd *, file_ptr, int));
static void
find_linenos PARAMS ((bfd *, sec_ptr, PTR));
@@ -2009,12 +2009,12 @@ PTR vpinfo;
static int
init_lineno (abfd, offset, size)
bfd *abfd;
long offset;
file_ptr offset;
int size;
{
int val;
if (bfd_seek(abfd, offset, 0) < 0)
if (bfd_seek(abfd, offset, L_SET) < 0)
return -1;
linetab = (char *) xmalloc(size);
@@ -2150,14 +2150,14 @@ xcoff_symfile_finish (objfile)
static int
init_stringtab(abfd, offset, objfile)
bfd *abfd;
long offset;
file_ptr offset;
struct objfile *objfile;
{
long length;
int val;
unsigned char lengthbuf[4];
if (bfd_seek(abfd, offset, 0) < 0)
if (bfd_seek(abfd, offset, L_SET) < 0)
return -1;
val = bfd_read((char *)lengthbuf, 1, sizeof lengthbuf, abfd);
@@ -2235,9 +2235,9 @@ xcoff_symfile_read (objfile, section_offset, mainline)
struct section_offset *section_offset;
int mainline;
{
int num_symbols; /* # of symbols */
int symtab_offset; /* symbol table and */
int stringtab_offset; /* string table file offsets */
int num_symbols; /* # of symbols */
file_ptr symtab_offset; /* symbol table and */
file_ptr stringtab_offset; /* string table file offsets */
int val;
bfd *abfd;
struct coff_symfile_info *info;
@@ -2262,7 +2262,7 @@ xcoff_symfile_read (objfile, section_offset, mainline)
/* only read in the line # table if one exists */
val = init_lineno(abfd, info->min_lineno_offset,
info->max_lineno_offset - info->min_lineno_offset);
(int) (info->max_lineno_offset - info->min_lineno_offset));
if (val < 0)
error("\"%s\": error reading line numbers\n", name);
@@ -2278,7 +2278,7 @@ xcoff_symfile_read (objfile, section_offset, mainline)
}
/* Position to read the symbol table. Do not read it all at once. */
val = bfd_seek(abfd, (long)symtab_offset, 0);
val = bfd_seek(abfd, symtab_offset, L_SET);
if (val < 0)
perror_with_name(name);