Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

* cli/cli-cmds.c (edit_command): Remove unused variables. Delete

Browse Source 
dead code.  Fix indentation.
This commit is contained in:
Tom Tromey
2008-07-30 01:08:35 +00:00
parent baea00a633
commit d5529a849e
2 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2008-07-29 Tom Tromey <tromey@redhat.com>
* cli/cli-cmds.c (edit_command): Remove unused variables. Delete
dead code. Fix indentation.
2008-07-29 Stan Shebs <stan@codesourcery.com> 2008-07-29 Stan Shebs <stan@codesourcery.com>
* main.c (captured_main): Remove long-unused #if 0 blocks. * main.c (captured_main): Remove long-unused #if 0 blocks.

25
gdb/cli/cli-cmds.c
View File

@@ -615,12 +615,10 @@ edit_command (char *arg, int from_tty)
struct symtab_and_line sal; struct symtab_and_line sal;
struct symbol *sym; struct symbol *sym;
char *arg1; char *arg1;
int cmdlen, log10;
unsigned m;
char *editor; char *editor;
char *p, *fn; char *p, *fn;
/* Pull in the current default source line if necessary */ /* Pull in the current default source line if necessary. */
if (arg == 0) if (arg == 0)
{ {
set_default_source_symtab_and_line (); set_default_source_symtab_and_line ();
@@ -638,13 +636,18 @@ edit_command (char *arg, int from_tty)
else else
{ {
/* Now should only be one argument -- decode it in SAL */ /* Now should only be one argument -- decode it in SAL. */
arg1 = arg; arg1 = arg;
sals = decode_line_1 (&arg1, 0, 0, 0, 0, 0); sals = decode_line_1 (&arg1, 0, 0, 0, 0, 0);
if (! sals.nelts) return; /* C++ */ if (! sals.nelts)
if (sals.nelts > 1) { {
/* C++ */
return;
}
if (sals.nelts > 1)
{
ambiguous_line_spec (&sals); ambiguous_line_spec (&sals);
xfree (sals.sals); xfree (sals.sals);
return; return;
@@ -656,7 +659,7 @@ edit_command (char *arg, int from_tty)
if (*arg1) if (*arg1)
error (_("Junk at end of line specification.")); error (_("Junk at end of line specification."));
/* if line was specified by address, /* If line was specified by address,
first print exactly which line, and which file. first print exactly which line, and which file.
In this case, sal.symtab == 0 means address is outside In this case, sal.symtab == 0 means address is outside
of all known source files, not that user failed to give a filename. */ of all known source files, not that user failed to give a filename. */
@@ -686,10 +689,6 @@ edit_command (char *arg, int from_tty)
if ((editor = (char *) getenv ("EDITOR")) == NULL) if ((editor = (char *) getenv ("EDITOR")) == NULL)
editor = "/bin/ex"; editor = "/bin/ex";
/* Approximate base-10 log of line to 1 unit for digit count */
for(log10=32, m=0x80000000; !(sal.line & m) && log10>0; log10--, m=m>>1);
log10 = 1 + (int)((log10 + (0 == ((m-1) & sal.line)))/3.32192809);
/* If we don't already know the full absolute file name of the /* If we don't already know the full absolute file name of the
source file, find it now. */ source file, find it now. */
if (!sal.symtab->fullname) if (!sal.symtab->fullname)
@@ -704,8 +703,8 @@ edit_command (char *arg, int from_tty)
/* Quote the file name, in case it has whitespace or other special /* Quote the file name, in case it has whitespace or other special
characters. */ characters. */
p = xstrprintf ("%s +%d \"%s\"", editor, sal.line, fn); p = xstrprintf ("%s +%d \"%s\"", editor, sal.line, fn);
shell_escape(p, from_tty); shell_escape (p, from_tty);
xfree(p); xfree (p);
} }
static void static void