Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

2011-08-12 Pedro Alves <pedro@codesourcery.com>

Browse Source 
PR tui/13073

	gdb/
	* tui/tui-regs.c (tui_show_register_group): Skip registers with an
	empty name.
	(tui_show_register_group): Don't store a byte buffer in the data
	element's value.
	(tui_register_format): Skip registers with an empty name.
	(tui_get_register): Store a struct value in the data element's
	value field instead of a byte buffer holding the raw register
	contents.  Account for optimized-out and unavailable registers
	when comparing register contents.
This commit is contained in:
Pedro Alves
2011-08-12 17:04:32 +00:00
parent 5d0bb2fbbc
commit d20c1c3fea
2 changed files with 45 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
gdb/ChangeLog
View File

@@ -1,3 +1,17 @@
2011-08-12 Pedro Alves <pedro@codesourcery.com>
PR tui/13073
* tui/tui-regs.c (tui_show_register_group): Skip registers with an
empty name.
(tui_show_register_group): Don't store a byte buffer in the data
element's value.
(tui_register_format): Skip registers with an empty name.
(tui_get_register): Store a struct value in the data element's
value field instead of a byte buffer holding the raw register
contents. Account for optimized-out and unavailable registers
when comparing register contents.
2011-08-09 Pedro Alves <pedro@codesourcery.com> 2011-08-09 Pedro Alves <pedro@codesourcery.com>
* printcmd.c (current_display_number): Update comment. * printcmd.c (current_display_number): Update comment.

56
gdb/tui/tui-regs.c
View File

@@ -230,10 +230,19 @@ tui_show_register_group (struct reggroup *group,
+ gdbarch_num_pseudo_regs (gdbarch); + gdbarch_num_pseudo_regs (gdbarch);
regnum++) regnum++)
{ {
/* Must be in the group and have a name. */ const char *name;
if (gdbarch_register_reggroup_p (gdbarch, regnum, group)
&& gdbarch_register_name (gdbarch, regnum) != 0) /* Must be in the group. */
nr_regs++; if (!gdbarch_register_reggroup_p (gdbarch, regnum, group))
continue;
/* If the register name is empty, it is undefined for this
processor, so don't display anything. */
name = gdbarch_register_name (gdbarch, regnum);
if (name == 0 || *name == '\0')
continue;
nr_regs++;
} }
if (display_info->regs_content_count > 0 && !refresh_values_only) if (display_info->regs_content_count > 0 && !refresh_values_only)
@@ -273,12 +282,15 @@ tui_show_register_group (struct reggroup *group,
struct tui_data_element *data; struct tui_data_element *data;
const char *name; const char *name;
/* Must be in the group. */
if (!gdbarch_register_reggroup_p (gdbarch, regnum, group)) if (!gdbarch_register_reggroup_p (gdbarch, regnum, group))
continue; continue;
name = gdbarch_register_name (gdbarch, regnum); /* If the register name is empty, it is undefined for this
if (name == 0) processor, so don't display anything. */
continue; name = gdbarch_register_name (gdbarch, regnum);
if (name == 0 || *name == '\0')
continue;
data_item_win = data_item_win =
&display_info->regs_content[pos]->which_element.data_window; &display_info->regs_content[pos]->which_element.data_window;
@@ -292,9 +304,6 @@ tui_show_register_group (struct reggroup *group,
data->name = name; data->name = name;
data->highlight = FALSE; data->highlight = FALSE;
} }
if (data->value == (void*) NULL)
data->value = (void*) xmalloc (MAX_REGISTER_SIZE);
tui_get_register (frame, data, regnum, 0); tui_get_register (frame, data, regnum, 0);
} }
pos++; pos++;
@@ -691,11 +700,9 @@ tui_register_format (struct frame_info *frame,
char *p, *s; char *p, *s;
name = gdbarch_register_name (gdbarch, regnum); name = gdbarch_register_name (gdbarch, regnum);
if (name == 0) if (name == 0 || *name == '\0')
{ return;
return;
}
pagination_enabled = 0; pagination_enabled = 0;
old_stdout = gdb_stdout; old_stdout = gdb_stdout;
stream = tui_sfileopen (256); stream = tui_sfileopen (256);
@@ -730,24 +737,23 @@ tui_get_register (struct frame_info *frame,
*changedp = FALSE; *changedp = FALSE;
if (target_has_registers) if (target_has_registers)
{ {
gdb_byte buf[MAX_REGISTER_SIZE]; struct value *old_val = data->value;
get_frame_register (frame, regnum, buf); data->value = get_frame_register_value (frame, regnum);
release_value (data->value);
if (changedp) if (changedp)
{ {
struct gdbarch *gdbarch = get_frame_arch (frame); struct gdbarch *gdbarch = get_frame_arch (frame);
int size = register_size (gdbarch, regnum); int size = register_size (gdbarch, regnum);
char *old = (char*) data->value;
int i;
for (i = 0; i < size; i++) if (value_optimized_out (data->value) != value_optimized_out (old_val)
if (buf[i] != old[i]) || !value_available_contents_eq (data->value, 0,
{ old_val, 0, size))
*changedp = TRUE; *changedp = TRUE;
old[i] = buf[i];
}
} }
value_free (old_val);
/* Reformat the data content if the value changed. */ /* Reformat the data content if the value changed. */
if (changedp == 0 || *changedp == TRUE) if (changedp == 0 || *changedp == TRUE)
tui_register_format (frame, data, regnum); tui_register_format (frame, data, regnum);