Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Re-implement ia64-linux-nat.c::ia64_linux_xfer_partial

Browse Source 
[description of this patch and ChangeLog entry by Joel Brobecker]
The recent implementation was questionable, and if it worked, it was
only by chance because the requested length is large enough that only
one read was sufficient.  Note that the implementation before that
also made that assumption, in the form of only handling
TARGET_OBJECT_UNWIND_TABLE xfer requests when offset was zero.

gdb/ChangeLog:

        * ia64-linux-nat.c (ia64_linux_xfer_partial): Reimplement
        handling of object == TARGET_OBJECT_UNWIND_TABLE.
This commit is contained in:
Pedro Alves
2014-02-25 20:45:50 -05:00
committed by Joel Brobecker
parent a8b1622022
commit d16461aeef
2 changed files with 27 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2014-02-25 Pedro Alves <palves@redhat.com>
* ia64-linux-nat.c (ia64_linux_xfer_partial): Reimplement
handling of object == TARGET_OBJECT_UNWIND_TABLE.
2014-02-25 Stan Shebs <stan@codesourcery.com>
* defs.h: Annotate comments for Doxygen.

33
gdb/ia64-linux-nat.c
View File

@@ -850,20 +850,31 @@ ia64_linux_xfer_partial (struct target_ops *ops,
{
if (object == TARGET_OBJECT_UNWIND_TABLE && readbuf != NULL)
{
gdb_byte *tmp_buf = alloca (offset + len);
ULONGEST xfered;
static long gate_table_size;
gdb_byte *tmp_buf;
long res;
xfered = syscall (__NR_getunwind, readbuf, offset + len);
if (xfered <= 0)
/* Probe for the table size once. */
if (gate_table_size == 0)
gate_table_size = syscall (__NR_getunwind, NULL, 0);
if (gate_table_size < 0)
return TARGET_XFER_E_IO;
else if (xfered <= offset)
if (offset >= gate_table_size)
return TARGET_XFER_EOF;
else
{
memcpy (readbuf, tmp_buf + offset, xfered - offset);
*xfered_len = xfered - offset;
return TARGET_XFER_OK;
}
tmp_buf = alloca (gate_table_size);
res = syscall (__NR_getunwind, tmp_buf, gate_table_size);
if (res < 0)
return TARGET_XFER_E_IO;
gdb_assert (res == gate_table_size);
if (offset + len > gate_table_size)
len = gate_table_size - offset;
memcpy (readbuf, tmp_buf + offset, len);
*xfered_len = len;
return TARGET_XFER_OK;
}
return super_xfer_partial (ops, object, annex, readbuf, writebuf,