diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 72e2d62c9fa..6170ccb702c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2021-03-07 Tom de Vries + + PR symtab/27341 + * dwarf2/read.c (read_array_type): Return NULL when not being able to + construct an array type. Add assert to ensure that element_type is + not being modified. + 2021-03-06 Kevin Buettner PR build/27536 diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index a025f04f48d..1dbeb113217 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -16854,6 +16854,14 @@ read_array_type (struct die_info *die, struct dwarf2_cu *cu) child_die = child_die->sibling; } + if (range_types.empty ()) + { + complaint (_("unable to find array range - DIE at %s [in module %s]"), + sect_offset_str (die->sect_off), + objfile_name (cu->per_objfile->objfile)); + return NULL; + } + /* Dwarf2 dimensions are output from left to right, create the necessary array types in backwards order. */ @@ -16875,6 +16883,8 @@ read_array_type (struct die_info *die, struct dwarf2_cu *cu) byte_stride_prop, bit_stride); } + gdb_assert (type != element_type); + /* Understand Dwarf2 support for vector types (like they occur on the PowerPC w/ AltiVec). Gcc just adds another attribute to the array type. This is not part of the Dwarf2/3 standard yet, but a diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 032ff34b410..d2057855af6 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2021-03-07 Tom de Vries + + PR symtab/27341 + * lib/gdb.exp (with_complaints): New proc, factored out of ... + (gdb_load_no_complaints): ... here. + * gdb.fortran/function-calls.exp: Add test-case. + 2021-02-02 Simon Marchi * lib/dwarf.exp (rnglists): Add -no-offset-array option to diff --git a/gdb/testsuite/gdb.fortran/function-calls.exp b/gdb/testsuite/gdb.fortran/function-calls.exp index a14cfaeb08a..00036d96c7c 100644 --- a/gdb/testsuite/gdb.fortran/function-calls.exp +++ b/gdb/testsuite/gdb.fortran/function-calls.exp @@ -24,6 +24,21 @@ if {[prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} {debug f90}]} { return -1 } +with_complaints 5 { + set cmd "maint expand-symtabs $srcfile" + set cmd_regexp [string_to_regexp $cmd] + set re_kfail [concat "During symbol reading:" \ + " unable to find array range"] + gdb_test_multiple $cmd "no complaints in srcfile" { + -re -wrap "$re_kfail.*" { + kfail symtab/27388 $gdb_test_name + } + -re "^$cmd_regexp\r\n$gdb_prompt $" { + pass $gdb_test_name + } + } +} + if {![runto [gdb_get_line_number "post_init"]]} then { perror "couldn't run to breakpoint post_init" continue diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 316d5ae1379..ff6e8c7e238 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -4977,6 +4977,62 @@ proc gdb_load { arg } { return 0 } +# +# with_complaints -- Execute BODY and set complaints temporary to N for the +# duration. +# +proc with_complaints { n body } { + global decimal + + # Save current setting of complaints. + set save "" + set show_complaints_re \ + "Max number of complaints about incorrect symbols is ($decimal)\\." + gdb_test_multiple "show complaints" "" { + -re -wrap $show_complaints_re { + set save $expect_out(1,string) + } + } + + if { $save == "" } { + perror "Did not manage to set complaints" + } else { + # Set complaints. + gdb_test_no_output "set complaints $n" "" + } + + set code [catch {uplevel 1 $body} result] + + # Restore saved setting of complaints. + if { $save != "" } { + gdb_test_no_output "set complaints $save" "" + } + + if {$code == 1} { + global errorInfo errorCode + return -code $code -errorinfo $errorInfo -errorcode $errorCode $result + } else { + return -code $code $result + } +} + +# +# gdb_load_no_complaints -- As gdb_load, but in addition verifies that +# loading caused no symbol reading complaints. +# +proc gdb_load_no_complaints { arg } { + global gdb_prompt gdb_file_cmd_msg decimal + + # Temporarily set complaint to a small non-zero number. + with_complaints 5 { + gdb_load $arg + } + + # Verify that there were no complaints. + set re "^Reading symbols from \[^\r\n\]*\r\n$gdb_prompt $" + gdb_assert {[regexp $re $gdb_file_cmd_msg]} "No complaints" +} + # gdb_reload -- load a file into the target. Called before "running", # either the first time or after already starting the program once, # for remote targets. Most files that override gdb_load should now