Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Use gdb_bfd_sections in build_objfile_section_table

Browse Source 
This changes build_objfile_section_table to avoid
bfd_map_over_sections, in favor of iteration.

gdb/ChangeLog
2020-09-19  Tom Tromey  <tom@tromey.com>

	* objfiles.c (add_to_objfile_sections): Rename from
	add_to_objfile_sections_full.
	(add_to_objfile_sections): Remove.
	(build_objfile_section_table): Use foreach.
This commit is contained in:
Tom Tromey
2020-09-19 11:54:49 -06:00
parent 3cabfd268b
commit cb814f2e30
2 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
gdb/objfiles.c
View File

@@ -257,13 +257,13 @@ objfile_lookup_static_link (struct objfile *objfile,
/* Called via bfd_map_over_sections to build up the section table that
the objfile references. The objfile contains pointers to the start
of the table (objfile->sections) and to the first location after
the end of the table (objfile->sections_end). */
/* Build up the section table that the objfile references. The
objfile contains pointers to the start of the table
(objfile->sections) and to the first location after the end of the
table (objfile->sections_end). */
static void
add_to_objfile_sections_full (struct bfd *abfd, struct bfd_section *asect,
add_to_objfile_sections (struct bfd *abfd, struct bfd_section *asect,
struct objfile *objfile, int force)
{
struct obj_section *section;
@@ -283,13 +283,6 @@ add_to_objfile_sections_full (struct bfd *abfd, struct bfd_section *asect,
section->ovly_mapped = 0;
}
static void
add_to_objfile_sections (struct bfd *abfd, struct bfd_section *asect,
void *objfilep)
{
add_to_objfile_sections_full (abfd, asect, (struct objfile *) objfilep, 0);
}
/* Builds a section table for OBJFILE.
Note that the OFFSET and OVLY_MAPPED in each table entry are
@@ -304,14 +297,14 @@ build_objfile_section_table (struct objfile *objfile)
count,
struct obj_section);
objfile->sections_end = (objfile->sections + count);
bfd_map_over_sections (objfile->obfd,
add_to_objfile_sections, (void *) objfile);
for (asection *sect : gdb_bfd_sections (objfile->obfd))
add_to_objfile_sections (objfile->obfd, sect, objfile, 0);
/* See gdb_bfd_section_index. */
add_to_objfile_sections_full (objfile->obfd, bfd_com_section_ptr, objfile, 1);
add_to_objfile_sections_full (objfile->obfd, bfd_und_section_ptr, objfile, 1);
add_to_objfile_sections_full (objfile->obfd, bfd_abs_section_ptr, objfile, 1);
add_to_objfile_sections_full (objfile->obfd, bfd_ind_section_ptr, objfile, 1);
add_to_objfile_sections (objfile->obfd, bfd_com_section_ptr, objfile, 1);
add_to_objfile_sections (objfile->obfd, bfd_und_section_ptr, objfile, 1);
add_to_objfile_sections (objfile->obfd, bfd_abs_section_ptr, objfile, 1);
add_to_objfile_sections (objfile->obfd, bfd_ind_section_ptr, objfile, 1);
}
/* Given a pointer to an initialized bfd (ABFD) and some flag bits,