Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Make save_infcall_*_state return unique pointers

Browse Source 
Simon pointed out that save_infcall_suspend_state and
save_infcall_control_state could return unique pointers.  This patch
implements this idea.

gdb/ChangeLog
2018-09-17  Tom Tromey  <tom@tromey.com>

	* infrun.c (save_infcall_suspend_state): Return
	infcall_suspend_state_up.
	(save_infcall_control_state): Return infcall_control_state_up.
	* inferior.h (save_infcall_suspend_state)
	(save_infcall_control_state): Declare later.  Return unique
	pointers.
This commit is contained in:
Tom Tromey
2018-07-11 13:29:59 -06:00
parent 2d844eaf9c
commit cb5248409d
3 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gdb/infrun.c
View File

@@ -8813,10 +8813,9 @@ struct infcall_suspend_state
gdb::unique_xmalloc_ptr<gdb_byte> siginfo_data;
};
struct infcall_suspend_state *
save_infcall_suspend_state (void)
infcall_suspend_state_up
save_infcall_suspend_state ()
{
struct infcall_suspend_state *inf_state;
struct thread_info *tp = inferior_thread ();
struct regcache *regcache = get_current_regcache ();
struct gdbarch *gdbarch = regcache->arch ();
@@ -8837,7 +8836,7 @@ save_infcall_suspend_state (void)
}
}
inf_state = new struct infcall_suspend_state;
infcall_suspend_state_up inf_state (new struct infcall_suspend_state);
if (siginfo_data)
{
@@ -8917,10 +8916,10 @@ struct infcall_control_state
/* Save all of the information associated with the inferior<==>gdb
connection. */
struct infcall_control_state *
save_infcall_control_state (void)
infcall_control_state_up
save_infcall_control_state ()
{
struct infcall_control_state *inf_status = new struct infcall_control_state;
infcall_control_state_up inf_status (new struct infcall_control_state);
struct thread_info *tp = inferior_thread ();
struct inferior *inf = current_inferior ();