Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix ia64-linux-nat.c

Browse Source 
PR build/23814 points out that ia64-linux-nat.c will not compile any
more.  This patch fixes the problem.  Thanks to Andreas Schwab for
trying the patch.

gdb/ChangeLog
2018-11-18  Tom Tromey  <tom@tromey.com>

	PR build/23814:
	* target-delegates.c: Rebuild.
	* ia64-linux-nat.c (class ia64_linux_nat_target)
	<have_steppable_watchpoint>: Use override.  Return true, not 1.
	(ia64_linux_nat_target::can_use_hw_breakpoint): Rename.  Remove
	"self" argument.
	(ia64_linux_nat_target::low_new_thread): Rename.
	(class ia64_linux_nat_target) <read_description>: Don't declare.
	* target.h (struct target_ops) <have_steppable_watchpoint>: Return
	bool.
This commit is contained in:
Tom Tromey
2018-11-14 09:29:51 -07:00
parent ad6d89178d
commit c2a6c5da37
4 changed files with 27 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gdb/ia64-linux-nat.c
View File

@@ -57,8 +57,6 @@ public:
ULONGEST offset, ULONGEST len,
ULONGEST *xfered_len) override;
const struct target_desc *read_description () override;
/* Override watchpoint routines. */
/* The IA-64 architecture can step over a watch point (without
@@ -70,7 +68,7 @@ public:
has determined that a hardware watchpoint has indeed been hit.
The CPU will then be able to execute one instruction without
triggering a watchpoint. */
bool have_steppable_watchpoint () { return 1; }
bool have_steppable_watchpoint () override { return true; }
int can_use_hw_breakpoint (enum bptype, int, int) override;
bool stopped_by_watchpoint () override;
@@ -672,8 +670,8 @@ ia64_linux_nat_target::remove_watchpoint (CORE_ADDR addr, int len,
return -1;
}
static void
ia64_linux_new_thread (struct lwp_info *lp)
void
ia64_linux_nat_target::low_new_thread (struct lwp_info *lp)
{
int i, any;
@@ -719,10 +717,9 @@ ia64_linux_nat_target::stopped_by_watchpoint ()
return stopped_data_address (&addr);
}
static int
ia64_linux_can_use_hw_breakpoint (struct target_ops *self,
enum bptype type,
int cnt, int othertype)
int
ia64_linux_nat_target::can_use_hw_breakpoint (enum bptype type,
int cnt, int othertype)
{
return 1;
}