Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Remove self-assign from make_invisible_and_set_new_height

Browse Source 
In https://sourceware.org/ml/gdb-patches/2019-07/msg00509.html, Jan
pointed out that clang points out that
make_invisible_and_set_new_height self-assigns "height".

This patch fixes the bug by renaming the formal parameter.

gdb/ChangeLog
2019-07-22  Tom Tromey  <tom@tromey.com>

	* tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
	Don't self-assign.
This commit is contained in:
Tom Tromey
2019-07-22 08:34:25 -06:00
parent 0c628bba5a
commit bfa2a36d94
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2019-07-22 Tom Tromey <tom@tromey.com>
* tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
Don't self-assign.
2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com> 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
* c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to

4
gdb/tui/tui-win.c
View File

@@ -1194,10 +1194,10 @@ tui_adjust_win_heights (struct tui_win_info *primary_win_info,
/* See tui-data.h. */ /* See tui-data.h. */
void void
tui_win_info::make_invisible_and_set_new_height (int height) tui_win_info::make_invisible_and_set_new_height (int height_)
{ {
make_visible (false); make_visible (false);
height = height; height = height_;
if (height > 1) if (height > 1)
viewport_height = height - 1; viewport_height = height - 1;
else else