Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

bfd_elf_define_start_stop: Fix check

Browse Source 
We really need to check for a dynamic def, not only a ref.
See added testcase.

bfd/
	* elflink.c (bfd_elf_define_start_stop): Fix check of
	def_dynamic.

ld/
	* testsuite/ld-elf/pr21964-5.c: New test.
	* testsuite/ld-elf/shared.exp: Run it.
This commit is contained in:
Michael Matz
2018-01-31 14:26:46 +01:00
parent 823143c6ca
commit bf3077a6c3
5 changed files with 42 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/elflink.c
View File

@@ -14338,8 +14338,9 @@ bfd_elf_define_start_stop (struct bfd_link_info *info,
if (h != NULL
&& (h->root.type == bfd_link_hash_undefined
|| h->root.type == bfd_link_hash_undefweak
|| ((h->ref_regular || h->ref_dynamic) && !h->def_regular)))
|| ((h->ref_regular || h->def_dynamic) && !h->def_regular)))
{
bfd_boolean was_dynamic = h->ref_dynamic || h->def_dynamic;
h->root.type = bfd_link_hash_defined;
h->root.u.def.section = sec;
h->root.u.def.value = 0;
@@ -14358,7 +14359,7 @@ bfd_elf_define_start_stop (struct bfd_link_info *info,
{
if (ELF_ST_VISIBILITY (h->other) == STV_DEFAULT)
h->other = (h->other & ~ELF_ST_VISIBILITY (-1)) | STV_PROTECTED;
if (h->ref_dynamic)
if (was_dynamic)
bfd_elf_link_record_dynamic_symbol (info, h);
}
return &h->root;