Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: Remove casts of NULL during assignment.

Browse Source 
In the following code:

    struct symbol *wsym = (struct symbol *) NULL;

the cast of NULL is redundant, it adds noise, and is just one more thing
to change if the type of wsym ever changes.  There are a relatively
small number of places in gdb where the above code pattern is used.
Usually the cast is removed like this:

    struct symbol *wsym = NULL;

This commit updates all the places within the gdb/ directory where we
cast NULL during assignment, removing the cast.

gdb/ChangeLog:

	* c-valprint.c (print_unpacked_pointer): Remove cast of NULL
	pointer.
	* dbxread.c (dbx_end_psymtab): Likewise.
	* gnu-nat.c (gnu_write_inferior): Likewise.
	* mdebugread.c (cross_ref): Likewise.
	* p-valprint.c (pascal_val_print): Likewise.
	* xcoffread.c (xcoff_end_psymtab): Likewise.
This commit is contained in:
Andrew Burgess
2015-08-31 21:19:49 +01:00
parent 02f024f9a5
commit be90335825
7 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/p-valprint.c
View File

@@ -239,9 +239,9 @@ pascal_val_print (struct type *type, const gdb_byte *valaddr,
if (vt_address && options->vtblprint)
{
struct value *vt_val;
struct symbol *wsym = (struct symbol *) NULL;
struct symbol *wsym = NULL;
struct type *wtype;
struct block *block = (struct block *) NULL;
struct block *block = NULL;
struct field_of_this_result is_this_fld;
if (want_space)