Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

* ax-gdb.c (gen_exp_binop_rest) [BINOP_SUBSCRIPT]: Error out on

Browse Source 
non-subscriptable types.
	* valarith.c (binop_types_user_defined_p): New, abstracted out
	from ...
	(binop_user_defined_p): ... this.
	* value.h (binop_types_user_defined_p): Declare.
This commit is contained in:
Pedro Alves
2010-02-11 21:45:25 +00:00
parent 10ef8d6a8d
commit be636754b7
4 changed files with 59 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
gdb/ax-gdb.c
View File

@@ -1885,11 +1885,35 @@ gen_expr_binop_rest (struct expression *exp,
aop_rem_signed, aop_rem_unsigned, 1, "remainder");
break;
case BINOP_SUBSCRIPT:
gen_ptradd (ax, value, value1, value2);
if (!pointer_type (value->type))
error (_("Invalid combination of types in array subscripting."));
gen_deref (ax, value);
break;
{
struct type *type;
if (binop_types_user_defined_p (op, value1->type, value2->type))
{
error (_("\
cannot subscript requested type: cannot call user defined functions"));
}
else
{
/* If the user attempts to subscript something that is not
an array or pointer type (like a plain int variable for
example), then report this as an error. */
type = check_typedef (value1->type);
if (TYPE_CODE (type) != TYPE_CODE_ARRAY
&& TYPE_CODE (type) != TYPE_CODE_PTR)
{
if (TYPE_NAME (type))
error (_("cannot subscript something of type `%s'"),
TYPE_NAME (type));
else
error (_("cannot subscript requested type"));
}
}
gen_ptradd (ax, value, value1, value2);
gen_deref (ax, value);
break;
}
case BINOP_BITWISE_AND:
gen_binop (ax, value, value1, value2,
aop_bit_and, aop_bit_and, 0, "bitwise and");