Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Tidy warn-execstack handling

Browse Source 
Make ld and bfd values consistent by swapping values 0 and 2 in
link_info.warn_execstack.  This has the benefit of making the value an
"extended" boolean, with 0 meaning no warning, 1 meaning warn, other
values a conditional warning.

Yes, this patch introduces fails on arm/aarch64.  Not a problem with
this patch but an arm/aarch64 before_parse problem.

bfd/
	* elflink.c (bfd_elf_size_dynamic_sections): Adjust
	warn_execstack test.
include/
	* bfdlink.h (warn_execstack): Swap 0 and 2 meaning.
ld/
	* configure.ac (DEFAULT_LD_WARN_EXECSTACK): Use values of 0,
	1, 2 consistent with link_info.warn_execstack.
	* ld.texi: Typo fixes.
	* lexsup.c (parse_args): Adjust setting of link_info.warn_execstack.
	(elf_static_list_options): Adjust help message conditions.
	* configure: Regenerate.
This commit is contained in:
Alan Modra
2022-05-20 14:59:05 +09:30
parent ef5d515048
commit bd7d326deb
6 changed files with 17 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/bfdlink.h
View File

@@ -493,12 +493,9 @@ struct bfd_link_info
unsigned int noexecstack: 1;
/* Tri-state variable:
0 => warn if the linker is creating an executable stack, but
execstack (above) is 0.
1 => warn if the linker is creating an executable stack; ignores
the value of execstack.
2 => do not warn.
3 => not used. */
0 => do not warn when creating an executable stack.
1 => always warn when creating an executable stack.
>1 => warn when creating an executable stack if execstack is 0. */
unsigned int warn_execstack: 2;
/* TRUE if warnings should not be generated for TLS segments with eXecute