gdb, testsuite: clean duplicate header includes

Some of the gdb and testsuite files double include some headers. While
all headers use include guards, it helps a bit keeping the code base
tidy.

No functional change.

Approved-by: Kevin Buettner <kevinb@redhat.com>

gdb/cli/cli-cmds.c

@@ -51,7 +51,6 @@
 #include "cli/cli-cmds.h"
 #include "cli/cli-style.h"
 #include "cli/cli-utils.h"
-#include "cli/cli-style.h"
 
 #include "extension.h"
 #include "gdbsupport/pathstuff.h"

gdb/fbsd-tdep.c

@@ -26,7 +26,6 @@
 #include "regcache.h"
 #include "regset.h"
 #include "gdbthread.h"
-#include "objfiles.h"
 #include "xml-syscall.h"
 #include <sys/socket.h>
 #include <arpa/inet.h>

gdb/m2-typeprint.c

@@ -27,7 +27,6 @@
 #include "gdbcore.h"
 #include "m2-lang.h"
 #include "target.h"
-#include "language.h"
 #include "demangle.h"
 #include "c-lang.h"
 #include "typeprint.h"

gdb/ppc-netbsd-tdep.c

@@ -28,7 +28,6 @@
 
 #include "ppc-tdep.h"
 #include "netbsd-tdep.h"
-#include "ppc-tdep.h"
 #include "solib-svr4.h"
 
 /* Register offsets from <machine/reg.h>.  */

gdb/stack.c

@@ -50,7 +50,6 @@
 #include "linespec.h"
 #include "cli/cli-utils.h"
 #include "objfiles.h"
-#include "annotate.h"
 
 #include "symfile.h"
 #include "extension.h"

gdb/testsuite/gdb.arch/sparc64-adi.c

@@ -31,7 +31,6 @@
 #include <string.h>
 #include <signal.h>
 #include <sys/shm.h>
-#include <errno.h>
 #include <sys/mman.h>
 #include <sys/stat.h>
 #include <fcntl.h>

gdb/testsuite/gdb.base/reset-catchpoint-cond-lib.c

@@ -20,7 +20,6 @@
 #include <unistd.h>
 #include <sys/types.h>
 #include <sys/wait.h>
-#include <unistd.h>
 #include <assert.h>
 #include <stdlib.h>
 

gdb/testsuite/gdb.debuginfod/corefile-mapped-file-3.c

@@ -17,7 +17,6 @@
 #include <sys/stat.h>
 #include <fcntl.h>
 #include <sys/types.h>
-#include <sys/stat.h>
 #include <unistd.h>
 #include <sys/mman.h>
 

gdb/testsuite/gdb.multi/multi-term-settings.c

@@ -22,7 +22,6 @@
 #include <stdio.h>
 #include <sys/types.h>
 #include <termios.h>
-#include <unistd.h>
 #include <signal.h>
 
 int

gdb/testsuite/gdb.server/exit-multiple-threads.c

@@ -20,7 +20,6 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <stdlib.h>
-#include <pthread.h>
 
 /* The number of threads to create.  */
 int thread_count = 3;

gdb/testsuite/gdb.threads/create-fail.c

@@ -23,10 +23,8 @@
 #include <errno.h>
 #include <string.h>
 #include <assert.h>
-#include <stdio.h>
 #include <sys/types.h>
 #include <dirent.h>
-#include <assert.h>
 #include <unistd.h>
 
 /* Count the number of tasks/threads in the PID thread group.  */

gdb/testsuite/gdb.threads/fork-thread-pending.c

@@ -21,7 +21,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <errno.h>
-#include <unistd.h>
 #include <sys/types.h>
 #include <sys/wait.h>
 

gdb/testsuite/gdb.threads/watchpoint-fork-mt.c

@@ -27,7 +27,6 @@
 #include <pthread.h>
 
 #include <asm/unistd.h>
-#include <unistd.h>
 #define gettid() syscall (__NR_gettid)
 
 /* Non-atomic `var++' should not hurt as we synchronize the threads by the STEP

gdb/valops.c

@@ -40,7 +40,6 @@
 #include "observable.h"
 #include "objfiles.h"
 #include "extension.h"
-#include "gdbtypes.h"
 #include "gdbsupport/byte-vector.h"
 #include "typeprint.h"