Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

aarch64: Make "info address" resolve TLS variables

Browse Source 
TLS variables can't be resolved on aarch64-linux-gnu

Running the test case with upstream gdb shows two failures:

(1) Receiving different error messages when printing TLS variable before
    program runs - because the ARM compiler does not emit dwarf attribute
    DW_AT_location for TLS, the result is expected and the baseline may
    need to be changed for aarch64.

(2) Using "info address" command on C++ static TLS object resulted in
    "symbol unresolved" error - below is a snippet from the test case:

class K {
 public:
  static __thread int another_thread_local;
};

__thread int K::another_thread_local;

(gdb) info address K::another_thread_local
Symbol "K::another_thread_local" is unresolved.

This patch contains fix for (2).

Function info_address_command() handles the "info address" command and
calls lookup_minimal_symbol_and_objfile() to find sym's symbol entry in
mininal symbol table if SYMBOL_COMPUTED_OPS (sym) is false. Problem is
that function lookup_minimal_symbol_and_objfile() only looked up an
objfile's minsym ordinary hash table, not its demangled hash table, which
was the reason why the C++ name was not found.

The fix is to call lookup_minimal_symbol(), which already looks up entries
in both minsym's hash tables, to find names when traversing the object file
list in lookup_minimal_symbol_and_objfile().

Tested in both aarch64-linux-gnu and amd64-linux-gnu. No regressions.
This commit is contained in:
Weimin Pan
2017-11-02 18:38:36 -06:00
committed by Simon Marchi
parent 9a96cf3834
commit bce02d8884
3 changed files with 10 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@@ -1,3 +1,9 @@
2017-11-01 Weimin Pan <weimin.pan@oracle.com>
* minsyms.c (lookup_minimal_symbol_and_objfile): Use
lookup_minimal_symbol() to find symbol entry.
* minsyms.h (lookup_minimal_symbol_and_objfile): Update comment.
2018-03-23 Keith Seitz <keiths@redhat.com> 2018-03-23 Keith Seitz <keiths@redhat.com>
PR c++/22968 PR c++/22968

17
gdb/minsyms.c
View File

@@ -1009,23 +1009,12 @@ lookup_minimal_symbol_and_objfile (const char *name)
{ {
struct bound_minimal_symbol result; struct bound_minimal_symbol result;
struct objfile *objfile; struct objfile *objfile;
unsigned int hash = msymbol_hash (name) % MINIMAL_SYMBOL_HASH_SIZE;
ALL_OBJFILES (objfile) ALL_OBJFILES (objfile)
{ {
struct minimal_symbol *msym; result = lookup_minimal_symbol (name, NULL, objfile);
if (result.minsym != NULL)
for (msym = objfile->per_bfd->msymbol_hash[hash]; return result;
msym != NULL;
msym = msym->hash_next)
{
if (strcmp (MSYMBOL_LINKAGE_NAME (msym), name) == 0)
{
result.minsym = msym;
result.objfile = objfile;
return result;
}
}
} }
memset (&result, 0, sizeof (result)); memset (&result, 0, sizeof (result));

2
gdb/minsyms.h
View File

@@ -203,7 +203,7 @@ struct bound_minimal_symbol lookup_minimal_symbol (const char *,
struct bound_minimal_symbol lookup_bound_minimal_symbol (const char *); struct bound_minimal_symbol lookup_bound_minimal_symbol (const char *);
/* Find the minimal symbol named NAME, and return both the minsym /* Find the minimal symbol named NAME, and return both the minsym
struct and its objfile. This only checks the linkage name. */ struct and its objfile. */
struct bound_minimal_symbol lookup_minimal_symbol_and_objfile (const char *); struct bound_minimal_symbol lookup_minimal_symbol_and_objfile (const char *);