Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdb/build] Fix unused var in corelow.c

Browse Source 
On x86_64-linux, with gcc 7.5.0 and CFLAGS/CXXFLAGS="-O0 -g -Wall" I ran into
a build breaker:
...
gdb/corelow.c: In member function ‘void mapped_file_info::add(const char*, const char*, const char*, std::vector<mem_range>&&, const bfd_build_id*)’:
gdb/corelow.c:1822:27: error: unused variable ‘it’ [-Werror=unused-variable]
   const auto [it, inserted]
                           ^
...

Fix this by dropping the variable it.

Tested on x86_64-linux.

Reviewed-By: Lancelot Six<lancelot.six@amd.com>
This commit is contained in:
Tom de Vries
2024-09-10 10:08:29 +02:00
parent c839a44c39
commit bc13da1980
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/corelow.c
View File

@@ -1819,8 +1819,8 @@ mapped_file_info::add (const char *soname,
parsed, we group the build-id information based on the file name. As parsed, we group the build-id information based on the file name. As
a consequence, we should see each EXPECTED_FILENAME value exactly a consequence, we should see each EXPECTED_FILENAME value exactly
once. This means that each insertion should always succeed. */ once. This means that each insertion should always succeed. */
const auto [it, inserted] const auto inserted
= m_filename_to_build_id_map.emplace (expected_filename, build_id); = m_filename_to_build_id_map.emplace (expected_filename, build_id).second;
gdb_assert (inserted); gdb_assert (inserted);
/* Setup the reverse build-id to file name map. */ /* Setup the reverse build-id to file name map. */