Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix crash in "document" command

Browse Source 
PR cli/29800 points out that "document" will now crash when the
argument is an undefined command.  This is a regression due to the
"document user-defined aliases" patch.

Approved-By: Joel Brobecker <brobecker@adacore.com>
Reviewed-By: Philippe Waroquiers <philippe.waroquiers@skynet.be>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29800
This commit is contained in:
Tom Tromey
2022-11-18 09:04:39 -07:00
parent 76cd77dc72
commit b70e9270fb
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/cli/cli-script.c
View File

@@ -1515,6 +1515,8 @@ do_document_command (const char *comname, int from_tty,
validate_comname (&comname); validate_comname (&comname);
lookup_cmd_composition (comfull, &alias, &prefix_cmd, &c); lookup_cmd_composition (comfull, &alias, &prefix_cmd, &c);
if (c == nullptr)
error (_("Undefined command: \"%s\"."), comfull);
if (c->theclass != class_user if (c->theclass != class_user
&& (alias == nullptr || alias->theclass != class_alias)) && (alias == nullptr || alias->theclass != class_alias))

4
gdb/testsuite/gdb.base/document.exp
View File

@@ -28,3 +28,7 @@ gdb_test_multiple "define do-document" "" {
} }
gdb_test_no_output "do-document" "invoke do-document" gdb_test_no_output "do-document" "invoke do-document"
gdb_test "help do-document" "usage: do-document" "invoke help do-document" gdb_test "help do-document" "usage: do-document" "invoke help do-document"
# Test that document of a non-existing command prints an error. There
# was a regression at one point causing this to crash.
gdb_test "document nosuchcommand" "Undefined command: \"nosuchcommand\"\\."