Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

remove exec_set_find_memory_regions

Browse Source 
exec_set_find_memory_regions is used to modify the exec target.
However, it only has a single caller, and so it is much clearer to
simply set the appropriate field directly.  It's also better for the
coming multi-target world to avoid this kind of global state change
anyway.

2014-02-19  Tom Tromey  <tromey@redhat.com>

	* gcore.h (objfile_find_memory_regions): Declare.
	* gcore.c (objfile_find_memory_regions): No longer static.  Add
	"self" argument.
	(_initialize_gcore): Don't call exec_set_find_memory_regions.
	* exec.c: Include gcore.h.
	(exec_set_find_memory_regions): Remove.
	(exec_find_memory_regions): Remove.
	(exec_do_find_memory_regions): Remove.
	(init_exec_ops): Update.
	* defs.h (exec_set_find_memory_regions): Remove.
This commit is contained in:
Tom Tromey
2014-01-15 09:40:13 -07:00
parent 9b1440374c
commit b427c1bc16
5 changed files with 21 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
gdb/exec.c
View File

@@ -34,6 +34,7 @@
#include "gdbthread.h"
#include "progspace.h"
#include "gdb_bfd.h"
#include "gcore.h"
#include <fcntl.h>
#include "readline/readline.h"
@@ -62,10 +63,6 @@ void _initialize_exec (void);
struct target_ops exec_ops;
/* Function used to implement to_find_memory_regions. */
static int (*exec_do_find_memory_regions) (find_memory_region_ftype, void *);
/* True if the exec target is pushed on the stack. */
static int using_exec_ops;
@@ -834,21 +831,6 @@ exec_has_memory (struct target_ops *ops)
!= current_target_sections->sections_end);
}
/* Find mapped memory. */
extern void
exec_set_find_memory_regions (int (*func) (find_memory_region_ftype, void *))
{
exec_do_find_memory_regions = func;
}
static int
exec_find_memory_regions (struct target_ops *self,
find_memory_region_ftype func, void *data)
{
return exec_do_find_memory_regions (func, data);
}
static char *exec_make_note_section (struct target_ops *self, bfd *, int *);
/* Fill in the exec file target vector. Very few entries need to be
@@ -873,7 +855,7 @@ Specify the filename of the executable file.";
exec_ops.to_stratum = file_stratum;
exec_ops.to_has_memory = exec_has_memory;
exec_ops.to_make_corefile_notes = exec_make_note_section;
exec_ops.to_find_memory_regions = exec_find_memory_regions;
exec_ops.to_find_memory_regions = objfile_find_memory_regions;
exec_ops.to_magic = OPS_MAGIC;
}