Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

2003-05-15 David Carlton <carlton@bactrian.org>

Browse Source 
Committed by Elena Zannoni <ezannoni@redhat.com>
        * symtab.c (lookup_symbol_aux): Delete calls to
        lookup_symbol_aux_minsyms.
        (lookup_symbol_aux_minsyms): Comment out function and
        prototype. Delete lookup by mangled name.
This commit is contained in:
Elena Zannoni
2003-05-15 14:28:57 +00:00
parent a15d9d3a98
commit ae2f03ac16
2 changed files with 17 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@@ -1,3 +1,11 @@
2003-05-15 David Carlton <carlton@bactrian.org>
Committed by Elena Zannoni <ezannoni@redhat.com>
* symtab.c (lookup_symbol_aux): Delete calls to
lookup_symbol_aux_minsyms.
(lookup_symbol_aux_minsyms): Comment out function and
prototype. Delete lookup by mangled name.
2003-05-14 Kevin Buettner <kevinb@redhat.com> 2003-05-14 Kevin Buettner <kevinb@redhat.com>
* dwarf2expr.c (new_dwarf_expr_context): Set ``stack_len'' to * dwarf2expr.c (new_dwarf_expr_context): Set ``stack_len'' to

61
gdb/symtab.c
View File

@@ -117,12 +117,14 @@ struct symbol *lookup_symbol_aux_psymtabs (int block_index,
const domain_enum domain, const domain_enum domain,
struct symtab **symtab); struct symtab **symtab);
#if 0
static static
struct symbol *lookup_symbol_aux_minsyms (const char *name, struct symbol *lookup_symbol_aux_minsyms (const char *name,
const char *mangled_name, const char *mangled_name,
const domain_enum domain, const domain_enum domain,
int *is_a_field_of_this, int *is_a_field_of_this,
struct symtab **symtab); struct symtab **symtab);
#endif
static struct symbol *find_active_alias (struct symbol *sym, CORE_ADDR addr); static struct symbol *find_active_alias (struct symbol *sym, CORE_ADDR addr);
@@ -1065,21 +1067,6 @@ lookup_symbol_aux (const char *name, const char *mangled_name,
if (sym != NULL) if (sym != NULL)
return sym; return sym;
#ifndef HPUXHPPA
/* Check for the possibility of the symbol being a function or
a mangled variable that is stored in one of the minimal symbol tables.
Eventually, all global symbols might be resolved in this way. */
sym = lookup_symbol_aux_minsyms (name, mangled_name,
domain, is_a_field_of_this,
symtab);
if (sym != NULL)
return sym;
#endif
sym = lookup_symbol_aux_psymtabs (GLOBAL_BLOCK, name, mangled_name, sym = lookup_symbol_aux_psymtabs (GLOBAL_BLOCK, name, mangled_name,
domain, symtab); domain, symtab);
if (sym != NULL) if (sym != NULL)
@@ -1101,33 +1088,6 @@ lookup_symbol_aux (const char *name, const char *mangled_name,
if (sym != NULL) if (sym != NULL)
return sym; return sym;
#ifdef HPUXHPPA
/* Check for the possibility of the symbol being a function or
a global variable that is stored in one of the minimal symbol tables.
The "minimal symbol table" is built from linker-supplied info.
RT: I moved this check to last, after the complete search of
the global (p)symtab's and static (p)symtab's. For HP-generated
symbol tables, this check was causing a premature exit from
lookup_symbol with NULL return, and thus messing up symbol lookups
of things like "c::f". It seems to me a check of the minimal
symbol table ought to be a last resort in any case. I'm vaguely
worried about the comment below which talks about FORTRAN routines "foo_"
though... is it saying we need to do the "minsym" check before
the static check in this case?
*/
sym = lookup_symbol_aux_minsyms (name, mangled_name,
domain, is_a_field_of_this,
symtab);
if (sym != NULL)
return sym;
#endif
if (symtab != NULL) if (symtab != NULL)
*symtab = NULL; *symtab = NULL;
return NULL; return NULL;
@@ -1304,6 +1264,7 @@ lookup_symbol_aux_psymtabs (int block_index, const char *name,
return NULL; return NULL;
} }
#if 0
/* Check for the possibility of the symbol being a function or a /* Check for the possibility of the symbol being a function or a
mangled variable that is stored in one of the minimal symbol mangled variable that is stored in one of the minimal symbol
tables. Eventually, all global symbols might be resolved in this tables. Eventually, all global symbols might be resolved in this
@@ -1317,6 +1278,11 @@ lookup_symbol_aux_psymtabs (int block_index, const char *name,
some additional conditions held as well, and it caused problems some additional conditions held as well, and it caused problems
with HP-generated symbol tables. */ with HP-generated symbol tables. */
/* NOTE: carlton/2003-05-14: This function was once used as part of
lookup_symbol. It is currently unnecessary for correctness
reasons, however, and using it doesn't seem to be any faster than
using lookup_symbol_aux_psymtabs, so I'm commenting it out. */
static struct symbol * static struct symbol *
lookup_symbol_aux_minsyms (const char *name, lookup_symbol_aux_minsyms (const char *name,
const char *mangled_name, const char *mangled_name,
@@ -1417,21 +1383,12 @@ lookup_symbol_aux_minsyms (const char *name,
*symtab = s; *symtab = s;
return fixup_symbol_section (sym, s->objfile); return fixup_symbol_section (sym, s->objfile);
} }
else if (MSYMBOL_TYPE (msymbol) != mst_text
&& MSYMBOL_TYPE (msymbol) != mst_file_text
&& !STREQ (name, DEPRECATED_SYMBOL_NAME (msymbol)))
{
/* This is a mangled variable, look it up by its
mangled name. */
return lookup_symbol_aux (DEPRECATED_SYMBOL_NAME (msymbol), mangled_name,
NULL, domain, is_a_field_of_this,
symtab);
}
} }
} }
return NULL; return NULL;
} }
#endif /* 0 */
/* Look, in partial_symtab PST, for symbol whose natural name is NAME. /* Look, in partial_symtab PST, for symbol whose natural name is NAME.
If LINKAGE_NAME is non-NULL, check in addition that the symbol's If LINKAGE_NAME is non-NULL, check in addition that the symbol's