Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Make find_separate_debug_file* return std::string

Browse Source 
This patch makes the find_separate_debug_file* functions return
std::string, which allows to get rid of some manual memory management
and one cleanup.

gdb/ChangeLog:

	* build-id.c (find_separate_debug_file_by_buildid): Return
	std::string.
	* build-id.h (find_separate_debug_file_by_buildid): Return
	std::string.
	* coffread.c (coff_symfile_read): Adjust to std::string.
	* elfread.c (elf_symfile_read): Adjust to std::string.
	* symfile.c (separate_debug_file_exists): Change parameter to
	std::string.
	(find_separate_debug_file): Return std::string.
	(find_separate_debug_file_by_debuglink): Return std::string.
	* symfile.h (find_separate_debug_file_by_debuglink): Return
	std::string.
This commit is contained in:
Simon Marchi
2018-03-08 18:56:23 -05:00
committed by Simon Marchi
parent e6a58aa8a7
commit a8dbfd5853
7 changed files with 66 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
gdb/coffread.c
View File

@@ -733,20 +733,17 @@ coff_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
/* Try to add separate debug file if no symbols table found. */
if (!objfile_has_partial_symbols (objfile))
{
char *debugfile;
std::string debugfile = find_separate_debug_file_by_buildid (objfile);
debugfile = find_separate_debug_file_by_buildid (objfile);
if (debugfile == NULL)
if (debugfile.empty ())
debugfile = find_separate_debug_file_by_debuglink (objfile);
make_cleanup (xfree, debugfile);
if (debugfile)
if (!debugfile.empty ())
{
gdb_bfd_ref_ptr abfd (symfile_bfd_open (debugfile));
gdb_bfd_ref_ptr abfd (symfile_bfd_open (debugfile.c_str ()));
symbol_file_add_separate (abfd.get (), debugfile, symfile_flags,
objfile);
symbol_file_add_separate (abfd.get (), debugfile.c_str (),
symfile_flags, objfile);
}
}