Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix fixed-point "return" on ARM

Browse Source 
On a big-endian ARM machine, the "return" command resulted in the
wrong value being returned when the function had a fixed-point return
type.  This patch fixes the problem by unpacking and repacking the
fixed-point type appropriately.

Approved-By: Luis Machado <luis.machado@arm.com>
This commit is contained in:
Tom Tromey
2023-09-20 11:29:53 -06:00
parent 47231c30a0
commit a23cf0c2ec
1 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
gdb/arm-tdep.c
View File

@@ -9170,16 +9170,28 @@ arm_store_return_value (struct type *type, struct regcache *regs,
|| type->code () == TYPE_CODE_BOOL
|| type->code () == TYPE_CODE_PTR
|| TYPE_IS_REFERENCE (type)
|| type->code () == TYPE_CODE_ENUM)
|| type->code () == TYPE_CODE_ENUM
|| is_fixed_point_type (type))
{
if (type->length () <= 4)
{
/* Values of one word or less are zero/sign-extended and
returned in r0. */
bfd_byte tmpbuf[ARM_INT_REGISTER_SIZE];
LONGEST val = unpack_long (type, valbuf);
store_signed_integer (tmpbuf, ARM_INT_REGISTER_SIZE, byte_order, val);
if (is_fixed_point_type (type))
{
gdb_mpz unscaled;
unscaled.read (gdb::make_array_view (valbuf, type->length ()),
byte_order, type->is_unsigned ());
unscaled.write (gdb::make_array_view (tmpbuf, sizeof (tmpbuf)),
byte_order, type->is_unsigned ());
}
else
{
LONGEST val = unpack_long (type, valbuf);
store_signed_integer (tmpbuf, ARM_INT_REGISTER_SIZE, byte_order, val);
}
regs->cooked_write (ARM_A1_REGNUM, tmpbuf);
}
else