* symfile.c (reread_symbols): Include bfd_errmsg string in error

message if bfd_close fails.
	* exec.c (exec_close), solib.c (clear_solib), corelow.c
	(core_close), objfiles.c (free_objfile), irix5-nat.c
	(clear_solib), osfsolib.c (clear_solib), remote-utils.c
	(gr_load_image): Check for errors from bfd_close.
	* solib.c (look_for_base), remote-utils.c (gr_load_image),
	remote-udi.c (download), corelow.c (core_open), symfile.c
	(symfile_bfd_open), symfile.c (generic_load): Add comment
	regarding error from bfd_close.
	* remote-udi.c (download), remote-utils.c (gr_load_image): Add
	comment about bogus handling of errors from bfd_openr.
	* exec.c (exec_close): Add comment regarding memory leak and
	dangling reference to vp->name.
This commit is contained in:
Jim Kingdon
1994-10-15 18:28:35 +00:00
parent e080a68fce
commit 9de0904cce
6 changed files with 28 additions and 8 deletions

View File

@@ -341,7 +341,9 @@ free_objfile (objfile)
if (objfile -> obfd != NULL)
{
char *name = bfd_get_filename (objfile->obfd);
bfd_close (objfile -> obfd);
if (!bfd_close (objfile -> obfd))
warning ("cannot close \"%s\": %s",
name, bfd_errmsg (bfd_get_error ()));
free (name);
}