Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Minor Ada task cleanups

Browse Source 
While working on the Ada task code, I noticed a few things that could
be cleaned up:

* task_list_valid_p was not set in all cases in ada_build_task_list.
  This causes many needless re-fetches of the task list.

* task_list_valid_p can be bool, and various functions can also return
  bool.

* Nothing checks the return value of read_known_tasks, so it can be
  changed to return void.

* The call to ada_build_task_list in
  ravenscar_thread_target::update_thread_list is redundant, because
  this is the first thing done by iterate_over_live_ada_tasks.

Tested using the internal AdaCore test suite against a ravenscar
target.

gdb/ChangeLog
2019-02-19  Tom Tromey  <tromey@adacore.com>

	* ravenscar-thread.c
	(ravenscar_thread_target::update_thread_list): Don't call
	ada_build_task_list.
	* ada-lang.h (ada_build_task_list): Don't declare.
	* ada-tasks.c (struct ada_tasks_inferior_data)
	<task_list_valid_p>: Now bool.
	(read_known_tasks, ada_task_list_changed)
	(ada_tasks_invalidate_inferior_data): Update.
	(read_known_tasks_array): Return bool.
	(read_known_tasks_list): Likewise.
	(read_known_tasks): Return void.
	(ada_build_task_list): Now static.
This commit is contained in:
Tom Tromey
2019-02-15 14:05:38 -07:00
parent 6f2117ba38
commit 98814c6c11
4 changed files with 42 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/ada-lang.h
View File

@@ -411,8 +411,6 @@ extern void iterate_over_live_ada_tasks
extern const char *ada_get_tcb_types_info (void);
extern int ada_build_task_list (void);
extern void print_ada_task_info (struct ui_out *uiout,
char *taskno_str,
struct inferior *inf);