Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Constify linetables

Browse Source 
Linetables no longer change after they are created.  This patch
applies const to them.

Note there is one hack to cast away const in mdebugread.c.  This code
allocates a linetable using 'malloc', then later copies it to the
obstack.  While this could be cleaned up, I chose not to do so because
I have no way of testing it.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Tom Tromey
2023-03-07 18:16:29 -07:00
parent 1acc9dca42
commit 977a0c161d
10 changed files with 54 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
gdb/buildsym.c
View File

@@ -916,13 +916,15 @@ buildsym_compunit::end_compunit_symtab_with_blockvector
size_t entry_array_size = n_entries * sizeof (struct linetable_entry);
int linetablesize = sizeof (struct linetable) + entry_array_size;
symtab->set_linetable
(XOBNEWVAR (&m_objfile->objfile_obstack, struct linetable,
linetablesize));
struct linetable *new_table
= XOBNEWVAR (&m_objfile->objfile_obstack, struct linetable,
linetablesize);
symtab->linetable ()->nitems = n_entries;
memcpy (symtab->linetable ()->item,
new_table->nitems = n_entries;
memcpy (new_table->item,
subfile->line_vector_entries.data (), entry_array_size);
symtab->set_linetable (new_table);
}
else
symtab->set_linetable (nullptr);