Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[spu] throw error when target_read_memory fails

Browse Source 
I happen to see that 1 is returned in spu_software_single_step when
target_read_memory returns 1.  It must be wrong.  That patch changes
it to throwing an error.  Note that I choose to throw error because I
find the code in the end of spu_software_single_step throws errors.

gdb:

2016-03-18  Yao Qi  <yao.qi@linaro.org>

	* spu-tdep.c (spu_software_single_step): Throw error when
	target_read_memory fails.
This commit is contained in:
Yao Qi
2016-03-18 14:39:09 +00:00
parent 35ac8b3e2d
commit 941319d151
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@@ -1,3 +1,8 @@
2016-03-18 Yao Qi <yao.qi@linaro.org>
* spu-tdep.c (spu_software_single_step): Throw error when
target_read_memory fails.
2016-03-17 Jan Kratochvil <jan.kratochvil@redhat.com> 2016-03-17 Jan Kratochvil <jan.kratochvil@redhat.com>
* linux-thread-db.c (check_pid_namespace_match): Extend the message. * linux-thread-db.c (check_pid_namespace_match): Extend the message.

4
gdb/spu-tdep.c
View File

@@ -1632,7 +1632,9 @@ spu_software_single_step (struct frame_info *frame)
pc = get_frame_pc (frame); pc = get_frame_pc (frame);
if (target_read_memory (pc, buf, 4)) if (target_read_memory (pc, buf, 4))
return 1; throw_error (MEMORY_ERROR, _("Could not read instruction at %s."),
paddress (gdbarch, pc));
insn = extract_unsigned_integer (buf, 4, byte_order); insn = extract_unsigned_integer (buf, 4, byte_order);
/* Get local store limit. */ /* Get local store limit. */