Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Pass alignment when using GCC_C_FE_VERSION_2

Browse Source 
When the GCC compiler plugin responds with GCC_C_FE_VERSION_2, gdb can
use the new 'finish_record_with_alignment' method.  This lets gdb pass
alignment information to the compiler, which in turn fixes the test
case included in this patch.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31397
This commit is contained in:
Tom Tromey
2024-02-21 08:22:01 -07:00
parent b0e7d28eae
commit 91e15dbaf9
3 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/compile/compile-c-types.c
View File

@@ -118,7 +118,11 @@ convert_struct_or_union (compile_c_instance *context, struct type *type)
type->field (i).loc_bitpos ());
}
context->plugin ().finish_record_or_union (result, type->length ());
if (context->plugin ().version () >= GCC_C_FE_VERSION_2)
context->plugin ().finish_record_with_alignment (result, type->length (),
type_align (type));
else
context->plugin ().finish_record_or_union (result, type->length ());
return result;
}

7
gdb/testsuite/gdb.compile/compile.c
View File

@@ -100,6 +100,13 @@ int globalshadow = 10;
static int staticshadow = 20;
int externed = 7;
struct struct_with_array
{
char val[7];
};
static struct struct_with_array swa;
int
main (void)
{

3
gdb/testsuite/gdb.compile/compile.exp
View File

@@ -397,3 +397,6 @@ gdb_test "p globalvar" " = 1" "expect 1"
gdb_test_no_output "compile code shlibvar += 5;" "modify shared library variable"
gdb_test "p shlibvar" " = 15" "expect 15"
# This used to fail due to alignment. PR compile/31397.
gdb_test_no_output "compile code swa.val\[0\] = 1"