Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: make frame_info_ptr auto-reinflatable

Browse Source 
This is the second step of making frame_info_ptr automatic, reinflate on
demand whenever trying to obtain the wrapper frame_info pointer, either
through the get method or operator->.  Make the reinflate method
private, it is used as a convenience method in those two.

Add an "is_null" method, because it is often needed to know whether the
frame_info_ptr wraps an frame_info or is empty.

Make m_ptr mutable, so that it's possible to reinflate const
frame_info_ptr objects.  Whether m_ptr is nullptr or not does not change
the logical state of the object, because we re-create it on demand.  I
believe this is the right use case for mutable.

Change-Id: Icb0552d0035e227f81eb3c121d8a9bb2f9d25794
Reviewed-By: Bruno Larsen <blarsen@redhat.com>
This commit is contained in:
Simon Marchi
2022-12-13 22:34:41 -05:00
parent 93e39555dd
commit 908de5e671
7 changed files with 36 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
gdb/infcmd.c
View File

@@ -1915,7 +1915,6 @@ finish_command (const char *arg, int from_tty)
print_stack_frame (callee_frame, 1, LOCATION, 0);
}
frame.reinflate ();
if (execution_direction == EXEC_REVERSE)
finish_backward (sm);