Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

libctf: archive: fix ctf_dict_open_cached error handling

Browse Source 
We were misreporting a failure to ctf_dict_open the dict as
an out-of-memory error.
This commit is contained in:
Nick Alcock
2025-04-25 21:08:51 +01:00
parent 02bfc04f73
commit 88f2c13d1c
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
libctf/ctf-archive.c
View File

@@ -717,7 +717,7 @@ static ctf_dict_t *
ctf_dict_open_cached (ctf_archive_t *arc, const char *name, int *errp)
{
ctf_dict_t *fp;
char *dupname;
char *dupname = NULL;
/* Just return from the cache if possible. */
if (arc->ctfi_dicts
@@ -728,10 +728,10 @@ ctf_dict_open_cached (ctf_archive_t *arc, const char *name, int *errp)
}
/* Not yet cached: open it. */
fp = ctf_dict_open (arc, name, errp);
dupname = strdup (name);
if ((fp = ctf_dict_open (arc, name, errp)) == NULL)
goto err;
if (!fp || !dupname)
if ((dupname = strdup (name)) == NULL)
goto oom;
if (arc->ctfi_dicts == NULL)
@@ -762,10 +762,11 @@ ctf_dict_open_cached (ctf_archive_t *arc, const char *name, int *errp)
return fp;
oom:
ctf_dict_close (fp);
free (dupname);
if (errp)
*errp = ENOMEM;
err:
ctf_dict_close (fp);
free (dupname);
return NULL;
}