Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Remove some uses of printf_unfiltered

Browse Source 
A number of spots call printf_unfiltered only because they are in code
that should not be interrupted by the pager.  However, I believe these
cases are all handled by infrun's blanket ban on paging, and so can be
converted to the default (_filtered) API.

After this patch, I think all the remaining _unfiltered calls are ones
that really ought to be.  A few -- namely in complete_command -- could
be replaced by a scoped assignment to pagination_enabled, but for the
remainder, the code seems simple enough like this.
This commit is contained in:
Tom Tromey
2022-01-08 16:31:44 -07:00
parent 9e4902bfac
commit 830df12588
16 changed files with 74 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
gdb/infrun.c
View File

@@ -1130,9 +1130,9 @@ follow_exec (ptid_t ptid, const char *exec_file_target)
/* What is this a.out's name? */
process_ptid = ptid_t (pid);
printf_unfiltered (_("%s is executing new program: %s\n"),
target_pid_to_str (process_ptid).c_str (),
exec_file_target);
printf_filtered (_("%s is executing new program: %s\n"),
target_pid_to_str (process_ptid).c_str (),
exec_file_target);
/* We've followed the inferior through an exec. Therefore, the
inferior has essentially been killed & reborn. */
@@ -4159,7 +4159,7 @@ fetch_inferior_event ()
&& exec_done_display_p
&& (inferior_ptid == null_ptid
|| inferior_thread ()->state != THREAD_RUNNING))
printf_unfiltered (_("completed.\n"));
printf_filtered (_("completed.\n"));
}
/* See infrun.h. */
@@ -8851,7 +8851,7 @@ Are you sure you want to change it? "),
sigs[signum] = 1;
}
else
printf_unfiltered (_("Not confirmed, unchanged.\n"));
printf_filtered (_("Not confirmed, unchanged.\n"));
}
break;
case GDB_SIGNAL_0: