Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Change return type of ui_out redirect to void

Browse Source 
All implementations of redirect/do_redirect in the ui_out subsystem
always return 0 (success).  We can therefore clean it up and make them
return void.

gdb/ChangeLog:

	* cli-out.c (cli_ui_out::do_redirect): Change return type to
	void.
	* cli-out.h (cli_ui_out::do_redirect): Likewise.
	* mi/mi-out.c (mi_ui_out::do_redirect): Likewise.
	* mi/mi-out.h (mi_ui_out::do_redirect): Likewise.
	* ui-out.c (ui_out::redirect): Likewise.
	* ui-out.h (ui_out::redirect, ui_out::do_redirect): Likewise.
	* cli/cli-logging.c (set_logging_redirect): Update call site of
	ui_out::redirect.
	(handle_redirections): Likewise.
	* scm-ports.c (ioscm_with_output_to_port_worker): Likewise.
	* top.c (execute_command_to_string): Likewise.
	* utils.c (do_ui_out_redirect_pop): Likewise.
This commit is contained in:
Simon Marchi
2017-01-10 11:30:47 -05:00
parent 98461510d3
commit 7becfd03ba
11 changed files with 34 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/top.c
View File

@@ -706,10 +706,8 @@ execute_command_to_string (char *p, int from_tty)
make_cleanup_ui_file_delete (str_file);
if (current_uiout->redirect (str_file) < 0)
warning (_("Current output protocol does not support redirection"));
else
make_cleanup_ui_out_redirect_pop (current_uiout);
current_uiout->redirect (str_file);
make_cleanup_ui_out_redirect_pop (current_uiout);
scoped_restore save_stdout
= make_scoped_restore (&gdb_stdout, str_file);