Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

asan: _bfd_elf_slurp_version_tables memory leak

Browse Source 
Extends commit 6136093c0d to handle verdefs as well as verrefs.

	PR 30886
	* elf.c (_bfd_elf_slurp_version_tables): See free_contents for
	verdefs too.  Use free_contents rather than elf_tdata fields.
This commit is contained in:
Alan Modra
2023-10-24 17:37:24 +10:30
parent 220be06018
commit 7ac6d0c38c
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/elf.c
View File

@@ -9571,7 +9571,7 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver)
}
elf_tdata (abfd)->cverrefs = i;
if (elf_tdata (abfd)->dt_verneed == NULL)
if (free_contents)
free (contents);
contents = NULL;
}
@@ -9618,6 +9618,7 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver)
if (contents == NULL)
goto error_return_verdef;
free_contents = true;
BFD_ASSERT (sizeof (Elf_External_Verdef)
>= sizeof (Elf_External_Verdaux));
@@ -9767,7 +9768,7 @@ _bfd_elf_slurp_version_tables (bfd *abfd, bool default_imported_symver)
((bfd_byte *) everdef + iverdef->vd_next));
}
if (elf_tdata (abfd)->dt_verdef == NULL)
if (free_contents)
free (contents);
contents = NULL;
}