Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

rescoff: ensure file is PE

Browse Source 
read_coff_rsrc makes one check on object file contents, the existence
of a .rsrc section.  It doesn't check that the file is PE but blindly
accesses bfd pe_data.  Fix that by adding the necessary checks.
Also, the "resources nest too deep" error isn't an overrun, ie. the
"address out of bounds" message isn't correct.  Fix that too.
This commit is contained in:
Alan Modra
2025-02-27 20:53:43 +10:30
parent 11b6914ce6
commit 7166166ec0
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
binutils/rescoff.c
View File

@@ -133,6 +133,9 @@ read_coff_rsrc (const char *filename, const char *target)
list_matching_formats (matching);
xexit (1);
}
if (bfd_get_flavour (abfd) != bfd_target_coff_flavour
|| !obj_pe (abfd))
fatal (_("%s: not a PE file"), filename);
sec = bfd_get_section_by_name (abfd, ".rsrc");
if (sec == NULL)
@@ -196,7 +199,7 @@ read_coff_res_dir (windres_bfd *wrbfd, const bfd_byte *data,
Microsoft only defines 3 levels. Corrupt files however might
claim to use more. */
if (level > 4)
overrun (flaginfo, _("Resources nest too deep"));
fatal (_("%s: resources nest too deep"), flaginfo->filename);
if ((size_t) (flaginfo->data_end - data) < sizeof (struct extern_res_directory))
overrun (flaginfo, _("directory"));