Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: remove other parameter in read_core_file_mappings parameter

Browse Source 
The `void *other` parameter in read_core_file_mappings' loop_cb
parameter is never used, remove it.

gdb/ChangeLog:

	* gdbarch.sh (read_core_file_mappings): Remove `other` parameter
	in `loop_cb` parameter.
	* gdbarch.c: Re-generate.
	* gdbarch.h: Re-generate.
	* arch-utils.c (default_read_core_file_mappings): Remove `other`
	parameter.
	* arch-utils.h (default_read_core_file_mappings): Likewise.
	* corelow.c (core_target::build_file_mappings): Likewise.
	* linux-tdep.c (linux_read_core_file_mappings): Likewise.
	(linux_core_info_proc_mappings): Likewise.

Change-Id: I6f408b4962b61b8a603642a844772b3026625523
This commit is contained in:
Simon Marchi
2020-11-19 10:34:57 -05:00
parent a5c641b57b
commit 70125a45e4
8 changed files with 23 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
gdb/ChangeLog
View File

@@ -1,3 +1,16 @@
2020-11-19 Simon Marchi <simon.marchi@polymtl.ca>
* gdbarch.sh (read_core_file_mappings): Remove `other` parameter
in `loop_cb` parameter.
* gdbarch.c: Re-generate.
* gdbarch.h: Re-generate.
* arch-utils.c (default_read_core_file_mappings): Remove `other`
parameter.
* arch-utils.h (default_read_core_file_mappings): Likewise.
* corelow.c (core_target::build_file_mappings): Likewise.
* linux-tdep.c (linux_read_core_file_mappings): Likewise.
(linux_core_info_proc_mappings): Likewise.
2020-11-19 Andrew Burgess <andrew.burgess@embecosm.com> 2020-11-19 Andrew Burgess <andrew.burgess@embecosm.com>
* Makefile.in (HFILES_NO_SRCDIR): Add f-array-walker.h. * Makefile.in (HFILES_NO_SRCDIR): Add f-array-walker.h.

3
gdb/arch-utils.c
View File

@@ -1045,8 +1045,7 @@ default_read_core_file_mappings (struct gdbarch *gdbarch,
ULONGEST start, ULONGEST start,
ULONGEST end, ULONGEST end,
ULONGEST file_ofs, ULONGEST file_ofs,
const char *filename, const char *filename)>
const void *other)>
loop_cb) loop_cb)
{ {
} }

3
gdb/arch-utils.h
View File

@@ -287,7 +287,6 @@ extern void default_read_core_file_mappings (struct gdbarch *gdbarch,
ULONGEST start, ULONGEST start,
ULONGEST end, ULONGEST end,
ULONGEST file_ofs, ULONGEST file_ofs,
const char *filename, const char *filename)>
const void *other)>
loop_cb); loop_cb);
#endif /* ARCH_UTILS_H */ #endif /* ARCH_UTILS_H */

2
gdb/corelow.c
View File

@@ -199,7 +199,7 @@ core_target::build_file_mappings ()
/* read_core_file_mappings will invoke this lambda for each mapping /* read_core_file_mappings will invoke this lambda for each mapping
that it finds. */ that it finds. */
[&] (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, [&] (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs,
const char *filename, const void *other) const char *filename)
{ {
/* Architecture-specific read_core_mapping methods are expected to /* Architecture-specific read_core_mapping methods are expected to
weed out non-file-backed mappings. */ weed out non-file-backed mappings. */

2
gdb/gdbarch.c
View File

@@ -5189,7 +5189,7 @@ set_gdbarch_get_pc_address_flags (struct gdbarch *gdbarch,
} }
void void
gdbarch_read_core_file_mappings (struct gdbarch *gdbarch, struct bfd *cbfd,gdb::function_view<void (ULONGEST count)> pre_loop_cb,gdb::function_view<void (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename, const void *other)> loop_cb) gdbarch_read_core_file_mappings (struct gdbarch *gdbarch, struct bfd *cbfd, gdb::function_view<void (ULONGEST count)> pre_loop_cb, gdb::function_view<void (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename)> loop_cb)
{ {
gdb_assert (gdbarch != NULL); gdb_assert (gdbarch != NULL);
gdb_assert (gdbarch->read_core_file_mappings != NULL); gdb_assert (gdbarch->read_core_file_mappings != NULL);

4
gdb/gdbarch.h
View File

@@ -1634,8 +1634,8 @@ extern void set_gdbarch_get_pc_address_flags (struct gdbarch *gdbarch, gdbarch_g
/* Read core file mappings */ /* Read core file mappings */
typedef void (gdbarch_read_core_file_mappings_ftype) (struct gdbarch *gdbarch, struct bfd *cbfd,gdb::function_view<void (ULONGEST count)> pre_loop_cb,gdb::function_view<void (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename, const void *other)> loop_cb); typedef void (gdbarch_read_core_file_mappings_ftype) (struct gdbarch *gdbarch, struct bfd *cbfd, gdb::function_view<void (ULONGEST count)> pre_loop_cb, gdb::function_view<void (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename)> loop_cb);
extern void gdbarch_read_core_file_mappings (struct gdbarch *gdbarch, struct bfd *cbfd,gdb::function_view<void (ULONGEST count)> pre_loop_cb,gdb::function_view<void (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename, const void *other)> loop_cb); extern void gdbarch_read_core_file_mappings (struct gdbarch *gdbarch, struct bfd *cbfd, gdb::function_view<void (ULONGEST count)> pre_loop_cb, gdb::function_view<void (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename)> loop_cb);
extern void set_gdbarch_read_core_file_mappings (struct gdbarch *gdbarch, gdbarch_read_core_file_mappings_ftype *read_core_file_mappings); extern void set_gdbarch_read_core_file_mappings (struct gdbarch *gdbarch, gdbarch_read_core_file_mappings_ftype *read_core_file_mappings);
extern struct gdbarch_tdep *gdbarch_tdep (struct gdbarch *gdbarch); extern struct gdbarch_tdep *gdbarch_tdep (struct gdbarch *gdbarch);

2
gdb/gdbarch.sh
View File

@@ -1178,7 +1178,7 @@ m;ULONGEST;type_align;struct type *type;type;;default_type_align;;0
f;std::string;get_pc_address_flags;frame_info *frame, CORE_ADDR pc;frame, pc;;default_get_pc_address_flags;;0 f;std::string;get_pc_address_flags;frame_info *frame, CORE_ADDR pc;frame, pc;;default_get_pc_address_flags;;0
# Read core file mappings # Read core file mappings
m;void;read_core_file_mappings;struct bfd *cbfd,gdb::function_view<void (ULONGEST count)> pre_loop_cb,gdb::function_view<void (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename, const void *other)> loop_cb;cbfd, pre_loop_cb, loop_cb;;default_read_core_file_mappings;;0 m;void;read_core_file_mappings;struct bfd *cbfd, gdb::function_view<void (ULONGEST count)> pre_loop_cb, gdb::function_view<void (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, const char *filename)> loop_cb;cbfd, pre_loop_cb, loop_cb;;default_read_core_file_mappings;;0
EOF EOF
} }

7
gdb/linux-tdep.c
View File

@@ -1072,8 +1072,7 @@ linux_read_core_file_mappings (struct gdbarch *gdbarch,
ULONGEST start, ULONGEST start,
ULONGEST end, ULONGEST end,
ULONGEST file_ofs, ULONGEST file_ofs,
const char *filename, const char *filename)>
const void *other)>
loop_cb) loop_cb)
{ {
/* Ensure that ULONGEST is big enough for reading 64-bit core files. */ /* Ensure that ULONGEST is big enough for reading 64-bit core files. */
@@ -1157,7 +1156,7 @@ linux_read_core_file_mappings (struct gdbarch *gdbarch,
char * filename = filenames; char * filename = filenames;
filenames += strlen ((char *) filenames) + 1; filenames += strlen ((char *) filenames) + 1;
loop_cb (i, start, end, file_ofs, filename, nullptr); loop_cb (i, start, end, file_ofs, filename);
} }
} }
@@ -1186,7 +1185,7 @@ linux_core_info_proc_mappings (struct gdbarch *gdbarch, const char *args)
} }
}, },
[=] (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs, [=] (int num, ULONGEST start, ULONGEST end, ULONGEST file_ofs,
const char *filename, const void *other) const char *filename)
{ {
if (gdbarch_addr_bit (gdbarch) == 32) if (gdbarch_addr_bit (gdbarch) == 32)
printf_filtered ("\t%10s %10s %10s %10s %s\n", printf_filtered ("\t%10s %10s %10s %10s %s\n",