Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

[gdbsupport] Use std::span-style iterators for gdb::array_view

Browse Source 
There's a plan to replace gdb::array_view with std::span (PR31422), and making
gdb::array_view more like std::span helps with that.

One difference is that std::span has:
...
constexpr iterator begin() const noexcept;
constexpr const_iterator cbegin() const noexcept;
...
while gdb::array_view has:
...
constexpr T *begin () noexcept;
constexpr const T *begin () const noexcept;
...

Fix this by renaming the second variant to cbegin, and making the first
variant const.

Likewise for gdb::array_view::end.

Tested on aarch64-linux.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Tom de Vries
2024-10-19 08:10:38 +02:00
parent 3173529d7d
commit 6c8052f6b2
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdbsupport/array-view.h
View File

@@ -157,11 +157,11 @@ public:
constexpr T *data () noexcept { return m_array; }
constexpr const T *data () const noexcept { return m_array; }
constexpr T *begin () noexcept { return m_array; }
constexpr const T *begin () const noexcept { return m_array; }
constexpr T *begin () const noexcept { return m_array; }
constexpr const T *cbegin () const noexcept { return m_array; }
constexpr T *end () noexcept { return m_array + m_size; }
constexpr const T *end () const noexcept { return m_array + m_size; }
constexpr T *end () const noexcept { return m_array + m_size; }
constexpr const T *cend () const noexcept { return m_array + m_size; }
constexpr reference operator[] (size_t index) noexcept
{