Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdb: rename type::{arch,objfile} -> type::{arch_owner,objfile_owner}

Browse Source 
I think this makes the names of the methods clearer, especially for the
arch.  The type::arch method (which gets the arch owner, or NULL if the
type is not arch owned) is easily confused with the get_type_arch method
(which returns an arch no matter what).  The name "arch_owner" will make
it intuitive that the method returns NULL if the type is not arch-owned.

Also, this frees the type::arch name, so we will be able to morph the
get_type_arch function into the type::arch method.

gdb/ChangeLog:

	* gdbtypes.h (struct type) <arch>: Rename to...
	<arch_owner>: ... this, update all users.
	<objfile>: Rename to...
	<objfile_owner>: ... this, update all users.

Change-Id: Ie7c28684c7b565adec05a7619c418c69429bd8c0
This commit is contained in:
Simon Marchi
2021-01-28 10:09:02 -05:00
parent cc3edc5274
commit 6ac373717c
12 changed files with 58 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/compile/compile-c-types.c
View File

@@ -165,9 +165,9 @@ convert_func (compile_c_instance *context, struct type *type)
if (target_type == NULL)
{
if (type->is_objfile_owned ())
target_type = objfile_type (type->objfile ())->builtin_int;
target_type = objfile_type (type->objfile_owner ())->builtin_int;
else
target_type = builtin_type (type->arch ())->builtin_int;
target_type = builtin_type (type->arch_owner ())->builtin_int;
warning (_("function has unknown return type; assuming int"));
}
@@ -324,9 +324,9 @@ convert_type_basic (compile_c_instance *context, struct type *type)
built-in parser used to do, but at least warn. */
struct type *fallback;
if (type->is_objfile_owned ())
fallback = objfile_type (type->objfile ())->builtin_int;
fallback = objfile_type (type->objfile_owner ())->builtin_int;
else
fallback = builtin_type (type->arch ())->builtin_int;
fallback = builtin_type (type->arch_owner ())->builtin_int;
warning (_("variable has unknown type; assuming int"));
return convert_int (context, fallback);
}