Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Make "bt N" print correct number of frames when using a frame filter

Browse Source 
PR python/16497 notes that using "bt" with a positive argument prints
the wrong number of frames when a frame filter is in use.  Also, in this
case, the non-frame-filter path will print a message about "More stack
frames" when there are more; but this is not done in the frame-filter
case.

The first problem is that backtrace_command_1 passes the wrong value
to apply_ext_lang_frame_filter -- that function takes the final
frame's number as an argument, but backtrace_command_1 passes the
count, which is off by one.

The solution to the second problem is to have the C stack-printing
code stop at the correct number of frames and then print the message.

Tested using the buildbot.

ChangeLog
2018-02-26  Tom Tromey  <tom@tromey.com>

	PR python/16497:
	* stack.c (backtrace_command_1): Set PRINT_MORE_FRAMES flag.  Fix
	off-by-one in py_end computation.
	* python/py-framefilter.c (gdbpy_apply_frame_filter): Handle
	PRINT_MORE_FRAMES.
	* extension.h (enum frame_filter_flags) <PRINT_MORE_FRAMES>: New
	constant.

2018-02-26  Tom Tromey  <tom@tromey.com>

	PR python/16497:
	* gdb.python/py-framefilter.exp: Update test.
This commit is contained in:
Tom Tromey
2016-06-20 10:36:29 -06:00
parent 2ddeaf8a7d
commit 6893c19a8b
6 changed files with 49 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gdb/extension.h
View File

@@ -100,6 +100,9 @@ enum frame_filter_flags
/* Set this flag if frame locals are to be printed. */
PRINT_LOCALS = 8,
/* Set this flag if a "More frames" message is to be printed. */
PRINT_MORE_FRAMES = 16,
};
/* A choice of the different frame argument printing strategies that