Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix regression in c-linkage-name.exp with gdb index

Browse Source 
c-linkage-name.exp started failing with the gdb-index target board due
to an earlier patch.  The problem here is that some linkage names must
be in the index -- but, based on inspection, not C++ linkage names.
This patch updates the code to exclude only these.
This commit is contained in:
Tom Tromey
2022-10-14 07:10:08 -06:00
parent c7f83b0d14
commit 67e83a0dee
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/dwarf2/index-write.c
View File

@@ -1111,12 +1111,13 @@ write_cooked_index (cooked_index_vector *table,
for (const cooked_index_entry *entry : table->all_entries ()) for (const cooked_index_entry *entry : table->all_entries ())
{ {
/* GDB never put linkage names into .gdb_index. The theory here /* GDB never put C++ linkage names into .gdb_index. The theory
is that a linkage name will normally be in the minimal here is that a linkage name will normally be in the minimal
symbols anyway, so including it in the index is usually symbols anyway, so including it in the index is usually
redundant -- and the cases where it would not be redundant redundant -- and the cases where it would not be redundant
are rare and not worth supporting. */ are rare and not worth supporting. */
if ((entry->flags & IS_LINKAGE) != 0) if (entry->per_cu->lang () == language_cplus
&& (entry->flags & IS_LINKAGE) != 0)
continue; continue;
const auto it = cu_index_htab.find (entry->per_cu); const auto it = cu_index_htab.find (entry->per_cu);