Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Rewrite target_read_string

Browse Source 
This rewrites target_read_string in terms of read_string.

gdb/ChangeLog
2020-06-15  Tom Tromey  <tromey@adacore.com>

	* valprint.c (read_string): Update comment.
	* target.c (MIN): Remove.
	(target_read_string): Rewrite.
This commit is contained in:
Tom Tromey
2020-06-15 06:28:09 -06:00
parent f5272a3bb3
commit 670e35fad9
3 changed files with 17 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/valprint.c
View File

@@ -2027,13 +2027,7 @@ partial_memory_read (CORE_ADDR memaddr, gdb_byte *myaddr,
Unless an exception is thrown, BUFFER will always be allocated, even on
failure. In this case, some characters might have been read before the
failure happened. Check BYTES_READ to recognize this situation.
Note: There was a FIXME asking to make this code use target_read_string,
but this function is more general (can read past null characters, up to
given LEN). Besides, it is used much more often than target_read_string
so it is more tested. Perhaps callers of target_read_string should use
this function instead? */
failure happened. Check BYTES_READ to recognize this situation. */
int
read_string (CORE_ADDR addr, int len, int width, unsigned int fetchlimit,