Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Remove unnecessary cases from rank_one_type's switch

Browse Source 
We return INCOMPATIBLE_TYPE_BADNESS for all these type codes, so we might as
well just let them go to the default case.

Incidentally, this patch also makes this false positive error go away when
compiling with gcc (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0, default compiler on
Ubuntu 18.04.

  CXX    gdbtypes.o
/home/smarchi/src/binutils-gdb/gdb/gdbtypes.c: In function ‘rank rank_one_type(type*, type*, value*)’:
/home/smarchi/src/binutils-gdb/gdb/gdbtypes.c:4259:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^

gdb/ChangeLog:

	* gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
This commit is contained in:
Simon Marchi
2019-03-08 10:15:12 -05:00
parent f09ce22d6a
commit 568c0683da
2 changed files with 4 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
gdb/gdbtypes.c
View File

@@ -4284,41 +4284,8 @@ rank_one_type (struct type *parm, struct type *arg, struct value *value)
return rank_one_type_parm_complex (parm, arg, value);
case TYPE_CODE_STRUCT:
return rank_one_type_parm_struct (parm, arg, value);
case TYPE_CODE_UNION:
switch (TYPE_CODE (arg))
{
case TYPE_CODE_UNION:
default:
return INCOMPATIBLE_TYPE_BADNESS;
}
break;
case TYPE_CODE_MEMBERPTR:
switch (TYPE_CODE (arg))
{
default:
return INCOMPATIBLE_TYPE_BADNESS;
}
break;
case TYPE_CODE_METHOD:
switch (TYPE_CODE (arg))
{
default:
return INCOMPATIBLE_TYPE_BADNESS;
}
break;
case TYPE_CODE_REF:
switch (TYPE_CODE (arg))
{
default:
return INCOMPATIBLE_TYPE_BADNESS;
}
break;
case TYPE_CODE_SET:
return rank_one_type_parm_set (parm, arg, value);
case TYPE_CODE_VOID:
default:
return INCOMPATIBLE_TYPE_BADNESS;
} /* switch (TYPE_CODE (arg)) */