Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

gdbsupport: make gdb_assert_not_reached accept a format string

Browse Source 
Change gdb_assert_not_reached to accept a format string plus
corresponding arguments.  This allows giving more precise messages.

Because the format string passed by the caller is prepended with a "%s:"
to add the function name, the callers can no longer pass a translated
string (`_(...)`).  Make the gdb_assert_not_reached include the _(),
just like the gdb_assert_fail macro just above.

Change-Id: Id0cfda5a57979df6cdaacaba0d55dd91ae9efee7
This commit is contained in:
Simon Marchi
2021-11-17 13:44:01 -05:00
parent ab19827912
commit 557b4d7650
19 changed files with 39 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gdbsupport/filestuff.cc
View File

@@ -215,7 +215,7 @@ unmark_fd_no_cloexec (int fd)
if (it != open_fds.end ())
open_fds.erase (it);
else
gdb_assert_not_reached (_("fd not found in open_fds"));
gdb_assert_not_reached ("fd not found in open_fds");
}
/* Helper function for close_most_fds that closes the file descriptor
@@ -378,7 +378,7 @@ gdb_socketpair_cloexec (int domain, int style, int protocol,
return result;
#else
gdb_assert_not_reached (_("socketpair not available on this host"));
gdb_assert_not_reached ("socketpair not available on this host");
#endif
}
@@ -419,7 +419,7 @@ gdb_pipe_cloexec (int filedes[2])
mark_cloexec (filedes[1]);
}
#else /* HAVE_PIPE */
gdb_assert_not_reached (_("pipe not available on this host"));
gdb_assert_not_reached ("pipe not available on this host");
#endif /* HAVE_PIPE */
#endif /* HAVE_PIPE2 */