Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Restore readelf's warnings that describe real problems with the file being examined. Fix bug displaying empty file name tables.

Browse Source 
binutils* dwarf.c (do_checks): New global variable.
	(display_formatted_table): Warn about an unexpected number of
	columns in the table, if checks are enabled.  Do not complain
	about the lack of data following the number of entries in the
	table if the table is empty.
	(display_debug_lines_decoded): Only warn about an unexpected
	number of columns in a table if checks are enabled.
	* dwarf.h (do_checks): Add a prototype.
	* elfcomm.c (error): Remove weak attribute.
	(warn): Likewise.
	* readelf.c (do_checks): Delete.
	(warn): Delete.
	(process_section_headers): Only warn about empty sections if
	checks are enabled.

gas	* dwarf2dbg.c (out_dir_and_file_list): Add comments describing the
	construction of a DWARF-5 directory name table.
	* testsuite/gas/elf/pr25917.d: Update expected output.
This commit is contained in:
Nick Clifton
2020-05-05 16:16:03 +01:00
parent 7d0bd48744
commit 546cb2d85e
9 changed files with 57 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
gas/dwarf2dbg.c
View File

@@ -1983,11 +1983,16 @@ out_dir_and_file_list (void)
/* Output the Directory Table. */
if (DWARF2_LINE_VERSION >= 5)
{
/* We only have one column in the directory table. */
out_byte (1);
/* Describe the purpose and format of the column. */
out_uleb128 (DW_LNCT_path);
/* FIXME: it would be better to store these strings in
the .debug_line_str section and reference them here. */
out_uleb128 (DW_FORM_string);
/* Now state how many rows there are in the table. */
out_uleb128 (dirs_in_use);
}