Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

ld testsuite: Sanitize output from ld

Browse Source 
Leading dashes from an LD error message confuse send_log, because the
string is taken to be an option.

This patch fixes the following DejaGnu error:

  --defsym:1: undefined symbol `foo2' referenced in expression
  failed with: <--defsym:1: undefined symbol `foo2' referenced in expression>, no expected output
  ERROR: tcl error sourcing .../ld/testsuite/ld-gc/gc.exp.
  ERROR: usage: send [args] string
      while executing
  "send_log "$comp_output\n""
      (procedure "run_dump_test" line 376)

	* testsuite/lib/ld-lib.exp (run_dump_test): Pass -- to send_log.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
This commit is contained in:
Dimitar Dimitrov
2016-12-30 12:39:59 +02:00
committed by Alan Modra
parent 3f66c01be3
commit 517c416698
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ld/ChangeLog
View File

@@ -1,3 +1,7 @@
2016-12-31 Dimitar Dimitrov <dimitar@dinux.eu>
* testsuite/lib/ld-lib.exp (run_dump_test): Pass -- to send_log.
2016-12-28 Alan Modra <amodra@gmail.com> 2016-12-28 Alan Modra <amodra@gmail.com>
PR ld/20995 PR ld/20995

6
ld/testsuite/lib/ld-lib.exp
View File

@@ -857,7 +857,7 @@ proc run_dump_test { name {extra_options {}} } {
remote_file build delete "ld.tmp" remote_file build delete "ld.tmp"
if { [lindex $cmdret 0] != 0 || ![string match "" $comp_output] } then { if { [lindex $cmdret 0] != 0 || ![string match "" $comp_output] } then {
send_log "$comp_output\n" send_log -- "$comp_output\n"
verbose "$comp_output" 3 verbose "$comp_output" 3
set exitstat "succeeded" set exitstat "succeeded"
@@ -880,7 +880,7 @@ proc run_dump_test { name {extra_options {}} } {
if { [lindex $cmdret 0] != 0 \ if { [lindex $cmdret 0] != 0 \
|| ![string match "" $comp_output] } { || ![string match "" $comp_output] } {
send_log "$comp_output\n" send_log -- "$comp_output\n"
verbose "$comp_output" 3 verbose "$comp_output" 3
set exitstat "succeeded" set exitstat "succeeded"
@@ -996,7 +996,7 @@ proc run_dump_test { name {extra_options {}} } {
} else { } else {
verbose -log "$exitstat with: <$comp_output>, no expected output" verbose -log "$exitstat with: <$comp_output>, no expected output"
} }
send_log "$comp_output\n" send_log -- "$comp_output\n"
verbose "$comp_output" 3 verbose "$comp_output" 3
if { (($check_ld(source) == "") == ($comp_output == "")) \ if { (($check_ld(source) == "") == ($comp_output == "")) \