Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Don't PROVIDE over top of common symbols

Browse Source 
This:
  int end[100000];
  int main(void) { end[99999] = 0; return 0; }
should not segfault.

ld/
	* ldexp.c (exp_fold_tree_1 <etree_provide>): Leave bfd_link_hash_common
	symbols alone.
ld/testsuite/
	* ld-elf/endsym.s, *ld-elf/endsym.d: New test.
This commit is contained in:
Alan Modra
2014-12-22 10:49:23 +10:30
parent cd8e2bcf0d
commit 4cc2bf08a4
5 changed files with 30 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
ld/ldexp.c
View File

@@ -1070,15 +1070,15 @@ exp_fold_tree_1 (etree_type *tree)
h = bfd_link_hash_lookup (link_info.hash, tree->assign.dst,
FALSE, FALSE, TRUE);
if (h == NULL
|| (h->type != bfd_link_hash_new
&& h->type != bfd_link_hash_undefined
&& h->type != bfd_link_hash_common
&& !(h->type == bfd_link_hash_defined
|| !(h->type == bfd_link_hash_new
|| h->type == bfd_link_hash_undefined
|| (h->type == bfd_link_hash_defined
&& (h->u.def.section->flags
& SEC_LINKER_CREATED) != 0)))
{
/* Do nothing. The symbol was never referenced, or was
defined by some object. */
/* Do nothing. The symbol was never referenced, or
was defined in some object file. Undefined weak
symbols stay undefined. */
break;
}
}