Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Simplify dwarf2-frame.c:read_addr_from_reg.

Browse Source 
Since 'struct dwarf_expr_context_funcs::read_addr_from_reg' is now
only used for addresses, we can make it use unpack_pointer.  And since
we now have 'struct dwarf_expr_context_funcs'::get_reg_value, there's
no need for speculation about using values here.

Tested on x86_64 Fedora 17.

gdb/
2013-11-18  Pedro Alves  <palves@redhat.com>

	* dwarf2-frame.c (read_addr_from_reg): Remove stale comment and
	use unpack_pointer.
This commit is contained in:
Pedro Alves
2013-11-18 12:05:11 +00:00
parent 176f037c0f
commit 4b4589ada7
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
gdb/dwarf2-frame.c
View File

@@ -298,12 +298,7 @@ read_addr_from_reg (void *baton, int reg)
buf = alloca (register_size (gdbarch, regnum));
get_frame_register (this_frame, regnum, buf);
/* Convert the register to an integer. This returns a LONGEST
rather than a CORE_ADDR, but unpack_pointer does the same thing
under the covers, and this makes more sense for non-pointer
registers. Maybe read_addr_from_reg and the associated interfaces
should deal with "struct value" instead of CORE_ADDR. */
return unpack_long (register_type (gdbarch, regnum), buf);
return unpack_pointer (register_type (gdbarch, regnum), buf);
}
/* Implement struct dwarf_expr_context_funcs' "get_reg_value" callback. */