forked from Imagelibrary/binutils-gdb
Fix DLL export forwarding
I noticed it when I was trying to set a breakpoint at ExitProcess:
```
(gdb) b ExitProcess
Breakpoint 1 at 0x14001fdd0
(gdb) r
Starting program: C:\qiewer\heob\heob64.exe
Warning:
Cannot insert breakpoint 1.
Cannot access memory at address 0x3dbf4120
Cannot insert breakpoint 1.
Cannot access memory at address 0x77644120
```
The problem doesn't exist in gdb 13.2, and the difference can easily be
seen when printing ExitProcess.
gdb 14.1:
```
(gdb) p ExitProcess
$1 = {<text variable, no debug info>} 0x77644120 <UserHandleGrantAccess+36128>
```
gdb 13.2:
```
(gdb) p ExitProcess
$1 = {<text variable, no debug info>} 0x77734120 <ntdll!RtlExitUserProcess>
```
The new behavior started with 9675da2535,
where VMA was then calculated relative to FORWARD_DLL_NAME, while it was
relative to DLL_NAME before.
Fixed by calculating VMA relative to DLL_NAME again.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31112
Approved-By: Tom Tromey <tom@tromey.com>
(cherry picked from commit 2574cd903d)
This commit is contained in:
@@ -210,7 +210,10 @@ add_pe_forwarded_sym (minimal_symbol_reader &reader,
|
|||||||
" \"%s\" in dll \"%s\", pointing to \"%s\"\n"),
|
" \"%s\" in dll \"%s\", pointing to \"%s\"\n"),
|
||||||
sym_name, dll_name, forward_qualified_name.c_str ());
|
sym_name, dll_name, forward_qualified_name.c_str ());
|
||||||
|
|
||||||
unrelocated_addr vma = msymbol.minsym->unrelocated_address ();
|
/* Calculate VMA as if it were relative to DLL_NAME/OBJFILE, even though
|
||||||
|
it actually points inside another dll (FORWARD_DLL_NAME). */
|
||||||
|
unrelocated_addr vma = unrelocated_addr (msymbol.value_address ()
|
||||||
|
- objfile->text_section_offset ());
|
||||||
msymtype = msymbol.minsym->type ();
|
msymtype = msymbol.minsym->type ();
|
||||||
section = msymbol.minsym->section_index ();
|
section = msymbol.minsym->section_index ();
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user