Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Move implementation of perror_with_name to gdbsupport

Browse Source 
gdbsupport/errors.h declares perror_with_name and leaves the
implementation to the clients.

However gdb and gdbserver's implementations are essentially the
same, resulting in unnecessary code duplication.

Fix this by implementing perror_with_name in gdbsupport.  Add an
optional parameter for specifying the errno used to generate the
error message.

Also move the implementation of perror_string to gdbsupport since
perror_with_name requires it.

Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Aaron Merey
2023-02-09 20:28:20 -05:00
parent bad727e2d2
commit 40dfb28b56
4 changed files with 35 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
gdbserver/utils.cc
View File

@@ -51,28 +51,6 @@ malloc_failure (long size)
abort_or_exit ();
}
/* Print the system error message for errno, and also mention STRING
as the file name for which the error was encountered.
Then return to command level. */
void
perror_with_name (const char *string)
{
const char *err;
char *combined;
err = safe_strerror (errno);
if (err == NULL)
err = "unknown error";
combined = (char *) alloca (strlen (err) + strlen (string) + 3);
strcpy (combined, string);
strcat (combined, ": ");
strcat (combined, err);
error ("%s.", combined);
}
/* Print an error message and return to top level. */
void