Toolchain/binutils-gdb
1
0
Fork 0
forked from Imagelibrary/binutils-gdb
Code Pull Requests Activity

Fix seg-fault in linker when passed a bogus input script.

Browse Source 
PR ld/20906
	* ldlex.l: Check for bogus strings in linker scripts.
This commit is contained in:
Nick Clifton
2016-12-05 16:00:43 +00:00
parent 9b5481c63a
commit 406bd128db
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ld/ChangeLog
View File

@@ -1,3 +1,8 @@
2016-12-05 Nick Clifton <nickc@redhat.com>
PR ld/20906
* ldlex.l: Check for bogus strings in linker scripts.
2016-12-05 Alyssa Milburn <amilburn@zall.org> 2016-12-05 Alyssa Milburn <amilburn@zall.org>
* testsuite/ld-sparc/wdispcall.s: New file. * testsuite/ld-sparc/wdispcall.s: New file.

10
ld/ldlex.l
View File

@@ -415,9 +415,15 @@ V_IDENTIFIER [*?.$_a-zA-Z\[\]\-\!\^\\]([*?.$_a-zA-Z0-9\[\]\-\!\^\\]|::)*
<EXPRESSION,BOTH,SCRIPT,VERS_NODE,INPUTLIST>"\""[^\"]*"\"" { <EXPRESSION,BOTH,SCRIPT,VERS_NODE,INPUTLIST>"\""[^\"]*"\"" {
/* No matter the state, quotes /* No matter the state, quotes
give what's inside */ give what's inside. */
bfd_size_type len;
yylval.name = xstrdup (yytext + 1); yylval.name = xstrdup (yytext + 1);
yylval.name[yyleng - 2] = 0; /* PR ld/20906. A corrupt input file
can contain bogus strings. */
len = strlen (yylval.name);
if (len > yyleng - 2)
len = yyleng - 2;
yylval.name[len] = 0;
return NAME; return NAME;
} }
<BOTH,SCRIPT,EXPRESSION>"\n" { lineno++;} <BOTH,SCRIPT,EXPRESSION>"\n" { lineno++;}